-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore/SOF-6394 #238
chore/SOF-6394 #238
Conversation
previousEnd = caption_time_to_milliseconds(caption["endTime"]) | ||
silence = caption_time_to_milliseconds(caption["startTime"]) - previous_end | ||
text = "".join((text, f"<break time='{silence}ms'/>", caption["text"])) | ||
previous_end = caption_time_to_milliseconds(caption["endTime"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
```json tab="Schema" | ||
{!esse/schema/properties_directory/structural/symmetry_symbol_point_group.json!} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's OK that we did this change for now, but we do have symmetry_symbol_point_group
and symmetry_symbol_space_group
as the working prototype in ESSE: Exabyte-io/esse#198. Storing simple strings makes things easier and we should probably continue in that direction.
in each material: | ||
$$ \Delta E_{v} = (\varepsilon_{v}^{A} - \overline{V}^{A}) - (\varepsilon_{v}^{B} - \overline{V}^{B}) $$ | ||
The second term, $\Delta V$, is determined from the lineup of the macroscopically averaged electrostatic potential in | ||
the interface heterostructure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we, perhaps, add some more explanation about the workflow? Maybe a link to the YAML source in WoDe.js, and a rough flowchart drawing?
Although there is a video, this page itself is rather dry without any visuals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the YAML source would not be much help, it is very difficult to learn from it if one doesn't know how wode.js works. I made a diagram of the workflow and embed it on the tutorial page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's at least link the two? Link to docs in wode and link to wode source in here
No description provided.