Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lndclient): unknown service lnrpc.Lightning #1045

Merged
merged 2 commits into from
Jun 19, 2019

Conversation

sangaman
Copy link
Collaborator

This fixes an issue where attempting a GetInfo call to lnd while lnd is locked results in an UNIMPLEMENTED grpc error that persists even after lnd has been unlocked and the GetInfo call becomes available. We close grpc clients after connection verification attempts so that we have a fresh start for future attempts

Fixes #1039.

sangaman added 2 commits June 19, 2019 08:18
This fixes an issue where attempting a `GetInfo` call to lnd while lnd
is locked results in an `UNIMPLEMENTED` grpc error that persists even
after lnd has been unlocked and the `GetInfo` call becomes available. We
close grpc clients after connection verification attempts so that we
have a fresh start for future attempts

Fixes #1039.
This fixes a typo and shortens the `noencrypt` description to fit on a
single line by default in a normal-sized terminal in Ubuntu.
@sangaman sangaman added bug Something isn't working lightning Lightning network & lnd integration labels Jun 19, 2019
@sangaman sangaman requested review from a user and kilrau June 19, 2019 12:29
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice catch.

@sangaman sangaman merged commit 03d213b into master Jun 19, 2019
@sangaman sangaman deleted the fix/lnd-unknown-service branch June 19, 2019 20:34
@sangaman sangaman self-assigned this Jun 25, 2019
@kilrau kilrau restored the fix/lnd-unknown-service branch July 6, 2019 11:20
@sangaman sangaman deleted the fix/lnd-unknown-service branch August 22, 2019 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lightning Lightning network & lnd integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xud doesn't try to connect to lnd if it's syncing
1 participant