feat(connext): estimate fee for closechannel #2026
Conversation
ghost
requested a review
from 
ghost
self-assigned this
| @@ -900,6 +901,21 @@ class ConnextClient extends SwapClient { | |||
| return parseInt(blockNumberResponse.result, 16); | |||
| } | |||
|
|
|||
| private getGasPrice = async () => { | |||
There was a problem hiding this comment.
A comment here would be helpful too in regards to what exactly this returns - is this getting the most recent average gas price? Or is this derived from some fee estimation logic built into geth?
There was a problem hiding this comment.
Shouldn't break anything on the rpc, but here a heads up for this upcoming change in geth how gas prices are calculated (moving from the current auction model/fee market based on which geth currently estimates gas prices -> moving average): ethereum/go-ethereum#21971
thanks for pointing me at it @michael1011
There was a problem hiding this comment.
The method call Karl is using returns data from GETHs internal fee estimation logic.
What Kilian mentioned is EIP-1559 which will be a breaking change in the way Ethereum handles gas prices and eventually be activated in a hardfork. But that won't matter for us since the REST endpoints of GETH won't change because of that.
This PR adds fee estimation logic to
ConnextClient.closeChannel. Previously, a static fee was used.Related issue: #2019