Skip to content
This repository has been archived by the owner on Jan 19, 2025. It is now read-only.

[Exiled::Events] Adding a list of all subscribed plugins' names #2569

Merged
merged 15 commits into from
Jun 23, 2024
Merged

[Exiled::Events] Adding a list of all subscribed plugins' names #2569

merged 15 commits into from
Jun 23, 2024

Conversation

VALERA771
Copy link
Contributor

No description provided.

@VALERA771 VALERA771 added enhancement New feature or request regarding-events An issue or PR targeting the Exiled Events project tested This PR has been built and tested and does not cause any obvious errors. labels May 22, 2024
@VALERA771 VALERA771 self-assigned this May 22, 2024
@VALERA771
Copy link
Contributor Author

TESTING NOTICE
Tested only with Exiled.Events (so some formatting issues may be).

iamalexrouse
iamalexrouse approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@iamalexrouse iamalexrouse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TESTING NOTICE Tested only with Exiled.Events (so some formatting issues may be).

I'll be the judge of that.

Jk, I think everything looks alright. Others may knitpick though.

Misfiy
Misfiy suggested changes May 22, 2024
View reviewed changes
Exiled.Events/Features/Event{T}.cs Outdated Show resolved Hide resolved
Exiled.Events/Features/Event{T}.cs Outdated Show resolved Hide resolved
Exiled.Events/Features/Event{T}.cs Outdated Show resolved Hide resolved
Exiled.Events/Features/Event{T}.cs Outdated Show resolved Hide resolved
Exiled.Events/Commands/PluginManager/DisplaySubscribed.cs Show resolved Hide resolved
@VALERA771 VALERA771 requested review from VladTheCow and Misfiy May 23, 2024 10:21
louis1706
louis1706 suggested changes May 24, 2024
View reviewed changes
Exiled.Events/Features/Event.cs Outdated Show resolved Hide resolved
Exiled.Events/Features/Event{T}.cs Outdated Show resolved Hide resolved
@VALERA771 VALERA771 requested a review from louis1706 May 24, 2024 15:31
@Misfiy Misfiy requested a review from NaoUnderscore May 29, 2024 17:41
@VladTheCow VladTheCow added the Do not merge Don't merge this PR label Jun 1, 2024
@VladTheCow
Copy link
Contributor

Until #2590 is merged

@VladTheCow VladTheCow removed the Do not merge Don't merge this PR label Jun 2, 2024
@NaoUnderscore NaoUnderscore merged commit 08fb711 into Exiled-Team:apis-rework Jun 23, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Misfiy Misfiy Misfiy approved these changes

@iamalexrouse iamalexrouse iamalexrouse approved these changes

@VladTheCow VladTheCow Awaiting requested review from VladTheCow

@louis1706 louis1706 Awaiting requested review from louis1706

@NaoUnderscore NaoUnderscore Awaiting requested review from NaoUnderscore

Assignees

@VALERA771 VALERA771

Labels
enhancement New feature or request regarding-events An issue or PR targeting the Exiled Events project tested This PR has been built and tested and does not cause any obvious errors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@VALERA771 @VladTheCow @louis1706 @Misfiy @iamalexrouse @NaoUnderscore @Misaka-ZeroTwo