Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] add encodingProcess and numColorComponents SOF members #2888

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

enen92
Copy link
Contributor

@enen92 enen92 commented Jan 9, 2024

Backport of #2874 and an alternative to #2887 due to the merge conflicts

@ghost
Copy link

ghost commented Jan 9, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (72129e7) 63.99% compared to head (1b257f6) 64.00%.
Report is 19 commits behind head on 0.28.x.

Files Patch % Lines
src/rafimage.cpp 0.00% 6 Missing ⚠️
src/canonmn_int.cpp 83.33% 1 Missing and 1 partial ⚠️
src/datasets.cpp 66.66% 0 Missing and 1 partial ⚠️
src/jpgimage.cpp 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           0.28.x    #2888   +/-   ##
=======================================
  Coverage   63.99%   64.00%           
=======================================
  Files         103      104    +1     
  Lines       22338    22360   +22     
  Branches    10821    10833   +12     
=======================================
+ Hits        14296    14311   +15     
- Misses       5818     5823    +5     
- Partials     2224     2226    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enen92 enen92 closed this Jan 9, 2024
@enen92 enen92 reopened this Jan 9, 2024
@enen92 enen92 closed this Jan 9, 2024
@enen92 enen92 reopened this Jan 9, 2024
@enen92 enen92 closed this Jan 10, 2024
@enen92 enen92 reopened this Jan 10, 2024
@neheb neheb merged commit 9b6ad75 into Exiv2:0.28.x Jan 11, 2024
386 of 410 checks passed
@kmilos kmilos added this to the v0.28.2 milestone Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants