Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport workflow changes to 0.28.x branch #2919

Merged
merged 6 commits into from
Feb 13, 2024

Conversation

kevinbackhouse
Copy link
Collaborator

These are changes that were made on the main branch but haven't been backported to 0.28.x yet. The only difference now is that I didn't backport special_noFilesystemAccess because I think that's a new feature on the main branch.

@ghost
Copy link

ghost commented Feb 13, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@kevinbackhouse kevinbackhouse added this to the v0.28.2 milestone Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (72129e7) 63.99% compared to head (981926b) 64.66%.
Report is 38 commits behind head on 0.28.x.

Files Patch % Lines
src/rafimage.cpp 0.00% 6 Missing ⚠️
src/quicktimevideo.cpp 88.00% 2 Missing and 1 partial ⚠️
src/value.cpp 86.36% 0 Missing and 3 partials ⚠️
src/canonmn_int.cpp 83.33% 1 Missing and 1 partial ⚠️
src/bmffimage.cpp 66.66% 0 Missing and 1 partial ⚠️
src/datasets.cpp 66.66% 0 Missing and 1 partial ⚠️
src/jp2image.cpp 50.00% 1 Missing ⚠️
src/jpgimage.cpp 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           0.28.x    #2919      +/-   ##
==========================================
+ Coverage   63.99%   64.66%   +0.66%     
==========================================
  Files         103      104       +1     
  Lines       22338    22169     -169     
  Branches    10821    10839      +18     
==========================================
+ Hits        14296    14335      +39     
+ Misses       5818     5590     -228     
- Partials     2224     2244      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kevinbackhouse kevinbackhouse mentioned this pull request Feb 13, 2024
@kmilos
Copy link
Collaborator

kmilos commented Feb 13, 2024

Shall we do one last compare after the last few commits to main?

@kevinbackhouse kevinbackhouse merged commit 48c20f4 into Exiv2:0.28.x Feb 13, 2024
57 checks passed
@kevinbackhouse kevinbackhouse deleted the backport-workflows branch February 13, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants