Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some ostringstreams #3157

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

remove some ostringstreams #3157

wants to merge 2 commits into from

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Feb 9, 2025

Looks like they're slow under Cygwin.

Maybe fixes #3153

src/tags.cpp Show resolved Hide resolved
@neheb neheb force-pushed the un branch 6 times, most recently from b51fa43 to 193ecdf Compare February 10, 2025 21:33
@neheb neheb marked this pull request as ready for review February 11, 2025 03:25
Looks like they're slow under Cygwin.

Signed-off-by: Rosen Penev <[email protected]>
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 58.98876% with 73 lines in your changes missing coverage. Please review.

Project coverage is 64.01%. Comparing base (ef6aa48) to head (d8bc93d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/nikonmn_int.cpp 43.75% 18 Missing and 9 partials ⚠️
src/properties.cpp 0.00% 10 Missing ⚠️
src/convert.cpp 70.83% 7 Missing ⚠️
src/pngchunk_int.cpp 0.00% 6 Missing ⚠️
src/samsungmn_int.cpp 0.00% 4 Missing ⚠️
src/casiomn_int.cpp 0.00% 3 Missing ⚠️
src/datasets.cpp 76.92% 2 Missing and 1 partial ⚠️
src/panasonicmn_int.cpp 40.00% 3 Missing ⚠️
include/exiv2/value.hpp 50.00% 0 Missing and 2 partials ⚠️
src/canonmn_int.cpp 89.47% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3157      +/-   ##
==========================================
- Coverage   64.18%   64.01%   -0.18%     
==========================================
  Files         104      104              
  Lines       22126    21838     -288     
  Branches    10832    10694     -138     
==========================================
- Hits        14202    13980     -222     
+ Misses       5708     5644      -64     
+ Partials     2216     2214       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExifKey::Impl::tagName() is Slow
2 participants