Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tamron 70-210mm F/4 Di VC USD for Nikon F #3165

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

nicegamer7
Copy link
Contributor

I tested this in Darktable, it works well.

@kmilos kmilos added the lens Issue related to lens detection label Feb 13, 2025
@kmilos
Copy link
Collaborator

kmilos commented Feb 13, 2025

Thanks! Please fix the clang-format error though: https://github.com/Exiv2/exiv2/actions/runs/13300921937/job/37147491042?pr=3165

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.18%. Comparing base (ef6aa48) to head (14df7a4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3165   +/-   ##
=======================================
  Coverage   64.18%   64.18%           
=======================================
  Files         104      104           
  Lines       22126    22126           
  Branches    10832    10832           
=======================================
  Hits        14202    14202           
  Misses       5708     5708           
  Partials     2216     2216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicegamer7
Copy link
Contributor Author

Should be good now.

Copy link
Collaborator

@kmilos kmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

(Unfortunately we just had 0.28.4 a couple of days ago and there's no plans/timeline yet for the next release... Users can rely on the exiv2.ini workaround in the meantime.)

@nicegamer7
Copy link
Contributor Author

No worries, I'm using a patched version locally for now. Thanks!

@kmilos kmilos merged commit 0a8d06c into Exiv2:main Feb 13, 2025
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lens Issue related to lens detection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants