Added customizable imagePullPolicy and imagePullSecrets (#34)

ExpediaGroup · Apr 12, 2022 · 6b01e8a · 6b01e8a
1 parent adec952
commit 6b01e8a
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/Makefile b/Makefile
@@ -30,7 +30,10 @@ kind-load: docker
 	kind load docker-image ${CONTAINER_NAME}:${IMAGE_TAG} --name ${KIND_CLUSTER}
 
 helm-install:
-	helm upgrade -i kubernetes-sidecar-injector ./charts/kubernetes-sidecar-injector/. --namespace=kubernetes-sidecar-injector --create-namespace --set image.tag=${IMAGE_TAG}
+	helm upgrade -i kubernetes-sidecar-injector ./charts/kubernetes-sidecar-injector/. --namespace=sidecar-injector --create-namespace --set image.tag=${IMAGE_TAG}
+
+helm-template:
+	helm template kubernetes-sidecar-injector ./charts/kubernetes-sidecar-injector
 
 kind-install: kind-load helm-install
 

diff --git a/charts/kubernetes-sidecar-injector/Chart.yaml b/charts/kubernetes-sidecar-injector/Chart.yaml
@@ -1,6 +1,6 @@
 name: kubernetes-sidecar-injector
 home: https://github.com/expediagroup/kubernetes-sidecar-injector
-version: 1.0.3
+version: 1.0.4
 appVersion: "0.1"
 keywords:
   - kubernetes

diff --git a/charts/kubernetes-sidecar-injector/templates/mutatingwebhook.yaml b/charts/kubernetes-sidecar-injector/templates/mutatingwebhook.yaml
@@ -100,7 +100,7 @@ spec:
       containers:
         - name: kubernetes-sidecar-injector
           image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
-          imagePullPolicy: IfNotPresent
+          imagePullPolicy: {{ .Values.image.pullPolicy }}
           args:
             - --port={{ .Values.container.port }}
             - --certFile=/opt/kubernetes-sidecar-injector/certs/cert.pem
@@ -136,6 +136,8 @@ spec:
             successThreshold: 1
             failureThreshold: 5
             timeoutSeconds: 4
+      imagePullSecrets:
+        {{- toYaml .Values.image.pullSecrets | nindent 8 }}
       volumes:
         - name: {{ .Release.Name }}-certs
           secret:

diff --git a/charts/kubernetes-sidecar-injector/values.yaml b/charts/kubernetes-sidecar-injector/values.yaml
@@ -1,6 +1,8 @@
 image:
   repository: expediagroup/kubernetes-sidecar-injector
   tag: latest
+  pullPolicy: IfNotPresent
+  pullSecrets: []
 
 replicaCount: 1