Remove 24% of Bedrock logs #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodnv
requested review from
iwiznia,
tylerkaraszewski,
danieldoglas and
coleaeason
tylerkaraszewski
previously approved these changes
Jan 14, 2025
iwiznia
previously approved these changes
Jan 14, 2025
tylerkaraszewski
previously approved these changes
Jan 14, 2025
iwiznia
previously approved these changes
Jan 14, 2025
coleaeason
previously approved these changes
Jan 14, 2025
flodnv
dismissed stale reviews from coleaeason, iwiznia, and tylerkaraszewski
via
26b1e97
|
Updated to remove a useless piece of a common log |
danieldoglas
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We're trying to reduce log volume which seems problematic during harvesting. All of these removed logs have existing counterparts.
Here are the log line counts for 37 seconds of such a period of time:
Fixed Issues
https://expensify.slack.com/archives/C05CBC62HGW/p1736772832409169?thread_ts=1736264200.243169&cid=C05CBC62HGW
Fixes https://github.com/Expensify/Expensify/issues/457478
Tests
none
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes