Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cache outside transactions #2067

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Disable cache outside transactions #2067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sqlitecluster/SQLite.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ bool SQLite::read(const string& query, SQResult& result, bool skipInfoWarn) cons
} else {
_isDeterministicQuery = true;
queryResult = !SQuery(_db, "read only query", query, result, 2000 * STIME_US_PER_MS, skipInfoWarn);
if (_isDeterministicQuery && queryResult) {
if (_isDeterministicQuery && queryResult && insideTransaction()) {
_queryCache.emplace(make_pair(query, result));
}
}
Expand Down
2 changes: 1 addition & 1 deletion sqlitecluster/SQLite.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ class SQLite {
const string getMostRecentSQLiteErrorLog() const;

// Returns true if we're inside an uncommitted transaction.
bool insideTransaction() { return _insideTransaction; }
bool insideTransaction() const { return _insideTransaction; }

// Looks up the exact SQL of a paricular commit to the database, as well as gets the SHA1 hash of the database
// immediately following tha commit.
Expand Down