Add rollback to postProcess #2081
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tylerkaraszewski does this fix make sense to you? 🙇 |
deetergp
approved these changes
Jan 30, 2025
|
I already fixed this here: #2067 which I think is a more general solution than this one but it hasn't been merged. |
|
Closing this PR because I confirmed that Tyler's fix #2067 is also fixing the bug (I ran the test 1000 times and they didn't fail) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Context: https://expensify.slack.com/archives/C05CBC62HGW/p1738208970608929?thread_ts=1738090282.125069&cid=C05CBC62HGW
It seems like
postProcessCommanddoesn't clear the db's query cache at the end, so it is possible that subsequent command'sprePeekmay read stale data from this cache. This can only happen for a subsequent command'sprePeekand notpeekbecausepeekclears the cache when it opens a new transaction.I'm not sure if this can happen in production, I was only able to confirm it running tests.
Fixed Issues
Fixes flakey tests mentioned here: https://github.com/Expensify/Auth/pull/13089#discussion_r1934500303
Tests
You have to run
ShareReportsWithAdminOrAuditorTesta lot of times while having checked out this PR: https://github.com/Expensify/Auth/pull/13089I ran the test 400 times without failure (before this fix, I got 8 failures in 200 runs)
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes