Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually track total class test times, not the time a thread is alive #2084

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

johnmlee101
Copy link
Contributor

@johnmlee101 johnmlee101 commented Feb 4, 2025

cc @tylerkaraszewski
I realized that the test times at the end are practically the full test time run, not the actual time we spent in a certain class. This fixes that.

Problem in auth:

  Slowest Test Classes: 
  235791ms: xxx
  234934ms: xxx
  230713ms: xxx
  228530ms: xxx
  227949ms: xx
  227831ms: xx
  227541ms: xx
  227226ms: xx
  227170ms: xx
  226947ms: xx

you can see some of these tests if you sum up their time actually don't count, so I realized this was a bug

result with 16 threads.

Slowest Test Classes:
28651ms: InfiniteRetryAfter : 28.5613% of total test time
23967ms: GetJob : 23.892% of total test time
12892ms: CreateJob : 12.8516% of total test time
10254ms: GetJobs : 10.2219% of total test time
8275ms: FailedJobReply : 8.2491% of total test time
4212ms: RequeueJobs : 4.19882% of total test time
2544ms: ChainedHTTP : 2.53604% of total test time
1341ms: Write : 1.3368% of total test time
1160ms: Query : 1.15637% of total test time
1156ms: CommandPort : 1.15238% of total test time
Total test time across threads: 100314ms

Details

Fixed Issues

Found this

Tests

See tests


Internal Testing Reminder: when changing bedrock, please compile auth against your new changes

@johnmlee101 johnmlee101 self-assigned this Feb 4, 2025
}
}

start = chrono::steady_clock::now();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hide whitespace since I fixed it off by one

@tylerkaraszewski tylerkaraszewski merged commit b4c6305 into main Feb 4, 2025
1 check passed
@tylerkaraszewski tylerkaraszewski deleted the john-fix-test branch February 4, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants