Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switches to NXscan for eln test #242

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Switches to NXscan for eln test #242

merged 1 commit into from
Feb 20, 2024

Conversation

domna
Copy link
Collaborator

@domna domna commented Feb 20, 2024

The eln test should not depend on the NXmpes definition as this may change.
I switched it to NXscan as this is a definition which is already contributed and will likely not change in the coming months.

@domna domna requested a review from RubelMozumder February 20, 2024 16:03
@coveralls
Copy link

coveralls commented Feb 20, 2024

Pull Request Test Coverage Report for Build 7976397026

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 12 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 44.561%

Files with Coverage Reduction New Missed Lines %
pynxtools/dataconverter/readers/shared/map_concepts/mapping_functors.py 1 11.86%
pynxtools/nexus/nxdl_utils.py 2 74.95%
pynxtools/eln_mapper/scheme_eln.py 3 89.72%
pynxtools/eln_mapper/eln.py 6 79.45%
Totals Coverage Status
Change from base Build 7961488576: -0.02%
Covered Lines: 4903
Relevant Lines: 11003

💛 - Coveralls

Copy link
Collaborator

@RubelMozumder RubelMozumder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just the chnage of the file to be subject in this tool and the change in the corresponding reference to the file. Everything looks fine

@domna domna merged commit 2724a65 into master Feb 20, 2024
7 checks passed
@domna domna deleted the use-nxscan-for-eln-test branch February 20, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants