Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse config before postprocess #388

Merged
merged 2 commits into from
Jul 23, 2024
Merged

parse config before postprocess #388

merged 2 commits into from
Jul 23, 2024

Conversation

lukaspie
Copy link
Collaborator

@lukaspie lukaspie commented Jul 23, 2024 •
edited
Loading

This is just to demonstrate how to post process the config dict given multiple entities.

@lukaspie lukaspie mentioned this pull request Jul 23, 2024
Merged
8 tasks
domna
domna approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@domna domna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good approach to expose the dict and being able to do post processing on it.

The changes being made for this look all good.

@lukaspie lukaspie marked this pull request as ready for review July 23, 2024 14:39
@lukaspie lukaspie merged commit b5e4f26 into multi-format-reader Jul 23, 2024
1 check passed
@lukaspie lukaspie deleted the parse-config-before-postprocess branch July 23, 2024 14:39
@lukaspie
Copy link
Collaborator Author

I think it's a good approach to expose the dict and being able to do post processing on it.

The changes being made for this look all good.

Great, I merged it in already now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domna domna domna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukaspie @domna