Remove unnecessary defaultdicts #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fedja
reviewed
Jun 28, 2022
| @@ -93,7 +93,6 @@ task sumstat_to_vcf { | |||
|
|
|||
| with gzip.open(sumstat, 'rt') as f: | |||
| h_idx = {h:i for i,h in enumerate(f.readline().strip().split(delim))} | |||
| h_idx = defaultdict(lambda: 1e9, h_idx) | |||
There was a problem hiding this comment.
and could error out with clear error message if there are missing columns.
Fedja
reviewed
Jun 28, 2022
| @@ -188,7 +188,6 @@ task sumstat_to_vcf { | |||
|
|
|||
| with gzip.open(sumstat, 'rt') as f: | |||
| h_idx = {h:i for i,h in enumerate(f.readline().strip().split(delim))} | |||
| h_idx = defaultdict(lambda: 1e9, h_idx) | |||
There was a problem hiding this comment.
if this is exactly the same sumstat_to_vcf, would be better to seaprate to commons wdl and import the task.
There was a problem hiding this comment.
Ah, of course that would be wise..
Fedja
reviewed
Jun 28, 2022
| @@ -327,7 +326,6 @@ task lift_postprocess { | |||
| s_f = gzip.open(sumstat, 'rt') | |||
| sumstat_header = s_f.readline().strip().split(delim) | |||
| sumstat_h_idx = {h:i for i,h in enumerate(sumstat_header)} | |||
| sumstat_h_idx = defaultdict(lambda: None, sumstat_h_idx) | |||
There was a problem hiding this comment.
same here that better explicitly check compulsory columns and error out instead of just key error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #53