FLA-510 Migrate to Standalone Workflow for Enhanced Customization and Improved Error Handling #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanced Customization - Updated FlaisApplicationReconciler to standalone mode, removing managed workflow. - Added all DependentResources and Conditions to Koin for improved dependency management. - Refactored the reconciliation flow to initialize CRD status before processing DependentResources.
…ID handling and dependent errors - Added test to check correlation ID is set if absent on FlaisApplication. - Added test to verify existing correlation ID is not overwritten. - Added test to handle and assert dependent errors during reconciliation. - Added dependetErrors to FlaisApplicationStatus
…FLA-501 - Added `ErrorStatusHandler` for custom error handling during dependent resource reconciliation. - Modified `determineNewStatus` to correctly update `dependentErrors` for errored dependents. - Updated state so its not set to `FAILED` until the last reconciliation attempt.
…inite update loops - FLA-502 - Added `@GradualRetry(maxAttempts = 3)` to `FlaisApplicationReconciler` to limit retry attempts for failed dependent resources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes:
Standalone Workflow Implementation:
Custom Error Handling:
ErrorStatusHandlerfor custom error handling of failed dependent resources.determineNewStatusto properly handle and reportdependentErrorsfor failed dependents.CRD Status Updates:
FlaisApplicationStatetoFAILEDuntil the final reconciliation attempt has been reached, ensuring retry logic is respected.Retry Logic for Dependent Resources:
@GradualRetry(maxAttempts = 3)onFlaisApplicationReconcilerto limit retries and prevent infinite update loops when dependent resources fail to deploy.Fixes: