<Do not review> pim6d: few fixes #11714

mobash-rasool · 2022-08-01T12:47:54Z

Trying to validate few things here.

Please ignore.

Signed-off-by: Mobashshera Rasool [email protected]

NetDEF-CI · 2022-08-01T15:02:08Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6742/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

NetDEF-CI · 2022-08-16T08:06:18Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6920/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Fedora 29 rpm pkg check: Failed (click for details)

Fedora 29 rpm pkg check: No useful log found

Successful on other platforms/tests

Debian 10 deb pkg check
Topotests Ubuntu 18.04 arm8 part 4
IPv6 protocols on Ubuntu 18.04
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 1
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 4
Ubuntu 18.04 deb pkg check
IPv4 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 i386 part 8
Debian 9 deb pkg check
Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 i386 part 3
Addresssanitizer topotests part 8
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 9
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 1
Static analyzer (clang)
Topotests Ubuntu 18.04 arm8 part 0
IPv4 ldp protocol on Ubuntu 18.04
Ubuntu 16.04 deb pkg check
Topotests debian 10 amd64 part 2
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 amd64 part 4
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 7
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 7
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 6
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 i386 part 5
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 i386 part 0

NetDEF-CI · 2022-08-16T10:37:00Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6931/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

NetDEF-CI · 2022-08-16T16:43:00Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6940/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

NetDEF-CI · 2022-08-18T15:33:14Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6980/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

NetDEF-CI · 2022-08-25T14:13:38Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7083/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

NetDEF-CI · 2022-08-26T11:28:58Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7093/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3U18I386-7093/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7093/artifact/TOPO3U18I386/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 1
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 amd64 part 0
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 1
Topotests debian 10 amd64 part 7
Topotests debian 10 amd64 part 5
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 8
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 2
Addresssanitizer topotests part 6
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 arm8 part 6
Addresssanitizer topotests part 5
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 8
IPv6 protocols on Ubuntu 18.04
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 4
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 9
IPv4 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 arm8 part 2
Static analyzer (clang)
Topotests Ubuntu 18.04 arm8 part 7
Topotests debian 10 amd64 part 0
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 0
IPv4 ldp protocol on Ubuntu 18.04
Topotests Ubuntu 18.04 amd64 part 8
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 7
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Debian 10 deb pkg check

NetDEF-CI · 2022-08-29T08:22:54Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7140/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for pim6_cmd.c | 8 issues
===============================================
< ERROR: code indent should use tabs where possible
< #507: FILE: /tmp/f1-997/pim6_cmd.c:507:
< WARNING: please, no spaces at the start of a line
< #507: FILE: /tmp/f1-997/pim6_cmd.c:507:
< ERROR: code indent should use tabs where possible
< #518: FILE: /tmp/f1-997/pim6_cmd.c:518:
< WARNING: please, no spaces at the start of a line
< #518: FILE: /tmp/f1-997/pim6_cmd.c:518:

NetDEF-CI · 2022-08-29T08:26:51Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7141/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for pim6_cmd.c | 8 issues
===============================================
< ERROR: code indent should use tabs where possible
< #507: FILE: /tmp/f1-30957/pim6_cmd.c:507:
< WARNING: please, no spaces at the start of a line
< #507: FILE: /tmp/f1-30957/pim6_cmd.c:507:
< ERROR: code indent should use tabs where possible
< #518: FILE: /tmp/f1-30957/pim6_cmd.c:518:
< WARNING: please, no spaces at the start of a line
< #518: FILE: /tmp/f1-30957/pim6_cmd.c:518:

NetDEF-CI · 2022-09-14T07:44:58Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7411/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for pim6_cmd.c | 8 issues
===============================================
< ERROR: code indent should use tabs where possible
< #507: FILE: /tmp/f1-1484/pim6_cmd.c:507:
< WARNING: please, no spaces at the start of a line
< #507: FILE: /tmp/f1-1484/pim6_cmd.c:507:
< ERROR: code indent should use tabs where possible
< #518: FILE: /tmp/f1-1484/pim6_cmd.c:518:
< WARNING: please, no spaces at the start of a line
< #518: FILE: /tmp/f1-1484/pim6_cmd.c:518:

NetDEF-CI · 2022-09-20T07:33:20Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7484/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for pim6_cmd.c | 8 issues
===============================================
< ERROR: code indent should use tabs where possible
< #507: FILE: /tmp/f1-23131/pim6_cmd.c:507:
< WARNING: please, no spaces at the start of a line
< #507: FILE: /tmp/f1-23131/pim6_cmd.c:507:
< ERROR: code indent should use tabs where possible
< #518: FILE: /tmp/f1-23131/pim6_cmd.c:518:
< WARNING: please, no spaces at the start of a line
< #518: FILE: /tmp/f1-23131/pim6_cmd.c:518:

LabN-CI · 2022-09-26T18:27:48Z

Outdated results 🚧

Basic BGPD CI results: Partial FAILURE, 2 tests failed

_	_
Result	SUCCESS git merge/11714 `17109d2`
Date	09/26/2022
Start	14:01:15
Finish	14:27:41
Run-Time	26:26
Total	1813
Pass	1811
Fail	2
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2022-09-26-14:01:15.txt
Log	autoscript-2022-09-26-14:02:31.log.bz2
Memory	549 551 464

For details, please contact louberger

NetDEF-CI · 2022-09-26T20:37:09Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7584/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7584/artifact/TOPO8U18ARM64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 8: No useful log found

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 8: No useful log found

Topotests Ubuntu 18.04 i386 part 8: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7584/artifact/TOPO8U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 8: No useful log found

Topotests debian 10 amd64 part 8: Failed (click for details)

Topotests debian 10 amd64 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7584/artifact/TOPO8DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 8: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 9
Topotests debian 10 amd64 part 2
Static analyzer (clang)
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 0
Ubuntu 18.04 deb pkg check
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 5
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 arm8 part 6
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Debian 9 deb pkg check
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 4
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 amd64 part 5
Ubuntu 16.04 deb pkg check
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 i386 part 3
Debian 10 deb pkg check
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 amd64 part 7
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 9
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 9
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check
Fedora 29 rpm pkg check

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7584/artifact/TOPO8U18ARM64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 8: No useful log found

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 8: No useful log found

Topotests Ubuntu 18.04 i386 part 8: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7584/artifact/TOPO8U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 8: No useful log found

Topotests debian 10 amd64 part 8: Failed (click for details)

Topotests debian 10 amd64 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7584/artifact/TOPO8DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 8: No useful log found

Report for pim6_cmd.c | 8 issues
===============================================
< ERROR: code indent should use tabs where possible
< #507: FILE: /tmp/f1-2148857/pim6_cmd.c:507:
< WARNING: please, no spaces at the start of a line
< #507: FILE: /tmp/f1-2148857/pim6_cmd.c:507:
< ERROR: code indent should use tabs where possible
< #518: FILE: /tmp/f1-2148857/pim6_cmd.c:518:
< WARNING: please, no spaces at the start of a line
< #518: FILE: /tmp/f1-2148857/pim6_cmd.c:518:
Report for pim_tib.c | 2 issues
===============================================
< ERROR: space required before the open parenthesis '('
< #179: FILE: /tmp/f1-2148857/pim_tib.c:179:

NetDEF-CI · 2022-10-03T12:41:08Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7682/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 1: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 8
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 arm8 part 9
Topotests debian 10 amd64 part 3
Debian 10 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 i386 part 3
Addresssanitizer topotests part 4
Debian 9 deb pkg check
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 i386 part 9
Addresssanitizer topotests part 7
Static analyzer (clang)
Ubuntu 16.04 deb pkg check
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 i386 part 6
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 0
Addresssanitizer topotests part 2
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 5
Fedora 29 rpm pkg check
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 3
Addresssanitizer topotests part 9
CentOS 7 rpm pkg check
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 8
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 i386 part 2
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 i386 part 5
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 7

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 1: No useful log found

Report for pim6_cmd.c | 8 issues
===============================================
< ERROR: code indent should use tabs where possible
< #507: FILE: /tmp/f1-228106/pim6_cmd.c:507:
< WARNING: please, no spaces at the start of a line
< #507: FILE: /tmp/f1-228106/pim6_cmd.c:507:
< ERROR: code indent should use tabs where possible
< #518: FILE: /tmp/f1-228106/pim6_cmd.c:518:
< WARNING: please, no spaces at the start of a line
< #518: FILE: /tmp/f1-228106/pim6_cmd.c:518:
Report for pim_zlookup.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for any arm of this statement
< #290: FILE: /tmp/f1-228106/pim_zlookup.c:290:

mobash-rasool · 2022-10-04T08:31:16Z

ci:rerun

NetDEF-CI · 2022-10-04T10:44:43Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7699/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Topotests Ubuntu 18.04 amd64 part 5: Incomplete

(check logs for details)

Successful on other platforms/tests

Static analyzer (clang)
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 2
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 9
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Addresssanitizer topotests part 6
Debian 10 deb pkg check
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 i386 part 9
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 6
Addresssanitizer topotests part 9
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 i386 part 7
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 7
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 2
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4
Topotests debian 10 amd64 part 8
Topotests debian 10 amd64 part 9
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 3

github-actions · 2022-10-13T13:25:23Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2023-04-12T01:51:22Z

This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.

NetDEF-CI · 2023-06-28T13:27:13Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12606/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-12606/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12606/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12606/artifact/TOPO9DEB10AMD64/TopotestDetails/

Successful on other platforms/tests

Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 6
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 2
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 9
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 3
Topotests debian 10 amd64 part 7
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 8
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 i386 part 3
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 3
Debian 10 deb pkg check
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 arm8 part 9
Debian 9 deb pkg check
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 2
Addresssanitizer topotests part 7
Static analyzer (clang)
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 5
Ubuntu 20.04 deb pkg check
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 i386 part 1

NetDEF-CI · 2023-06-28T14:07:51Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12610/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-12610/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12610/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12610/artifact/TOPO9DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12610/artifact/TP1U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-12610/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12610/artifact/TP1U1804AMD64/TopotestLogs/log_topotests.txt

Successful on other platforms/tests

Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 7
Addresssanitizer topotests part 2
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 5
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 2
Topotests debian 10 amd64 part 0
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 i386 part 2
CentOS 7 rpm pkg check
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 5
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 8
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 9
Debian 10 deb pkg check
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 i386 part 3
Addresssanitizer topotests part 4
Debian 9 deb pkg check
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 i386 part 9
Addresssanitizer topotests part 7
Static analyzer (clang)
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 i386 part 1
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 0

Problem Statement: =================== Syscall param sendmsg(msg.msg_iov[0]) points to uninitialised byte(s) at 0x4975157: sendmsg (sendmsg.c:28) ==2263111== by 0x1413BE: pim_msg_send_frame (pim_pim.c:629) ==2263111== by 0x1413BE: pim_msg_send (pim_pim.c:743) ==2263111== by 0x1425DC: pim_register_send (pim_register.c:332) ==2263111== by 0x1427EE: pim_null_register_send (pim_register.c:443) ==2263111== by 0x14D228: pim_upstream_register_stop_timer (pim_upstream.c:1608) ==2263111== by 0x48CE6DF: thread_call (thread.c:1693) ==2263111== by 0x4899EFF: frr_run (libfrr.c:1068) ==2263111== by 0x11D035: main (pim6_main.c:190) ==2263111== Address 0x1ffeffdcb1 is on thread 1's stack ==2263111== in frame #2, created by pim_register_send (pim_register.c:273) ==2263111== Uninitialised value was created by a stack allocation ==2263111== at 0x142690: pim_null_register_send (pim_register.c:389) RCA: ==================== 1. All members of struct pim_msg_header were not initiliased while sending null register packet. Therefore when the pointers are assigned while sending the msg via sendmsg, it complains the pointer points to uninitialised byte. 2. struct ipv6_ph ph was also not initialised. Fix: ==================== Initialised all the members using memset. Signed-off-by: Mobashshera Rasool <[email protected]>

mobash-rasool · 2023-10-17T04:43:34Z

Closing the PR since it is no more required.

mobash-rasool added the pimv6 label Aug 1, 2022

github-actions bot added the master label Aug 1, 2022

mobash-rasool force-pushed the fixes branch from 1006598 to 0844fdc Compare August 16, 2022 05:52

mobash-rasool force-pushed the fixes branch from 1c0cffa to ac2dd93 Compare August 16, 2022 14:25

frrbot bot added the bugfix label Aug 16, 2022

mobash-rasool force-pushed the fixes branch from ac2dd93 to b10f68f Compare August 18, 2022 13:19

mobash-rasool force-pushed the fixes branch from b10f68f to 8439837 Compare August 25, 2022 11:58

mobash-rasool force-pushed the fixes branch from 8439837 to 0754f88 Compare August 26, 2022 09:14

mobash-rasool force-pushed the fixes branch from 0754f88 to c9f7e73 Compare August 29, 2022 06:09

mobash-rasool force-pushed the fixes branch from cc463a5 to fde1853 Compare September 14, 2022 05:13

mobash-rasool force-pushed the fixes branch from fde1853 to 04511c1 Compare September 20, 2022 05:13

mobash-rasool force-pushed the fixes branch from 04511c1 to 17109d2 Compare September 26, 2022 17:56

frrbot bot added the pim label Sep 26, 2022

mobash-rasool force-pushed the fixes branch from 17109d2 to 83056e5 Compare October 3, 2022 10:16

github-actions bot added the conflicts label Oct 13, 2022

github-actions bot added the autoclose label Apr 12, 2023

mobash-rasool force-pushed the fixes branch from 83056e5 to ad0e730 Compare June 28, 2023 10:25

github-actions bot added size/M and removed conflicts labels Jun 28, 2023

mobash-rasool force-pushed the fixes branch from ad0e730 to 7db379e Compare June 28, 2023 11:09

github-actions bot removed the autoclose label Jul 24, 2023

FRRouting deleted a comment from LabN-CI Jul 26, 2023

mobash-rasool force-pushed the fixes branch from 7db379e to e835ac7 Compare October 17, 2023 04:41

github-actions bot added size/XS and removed size/M labels Oct 17, 2023

mobash-rasool closed this Oct 17, 2023

<Do not review> pim6d: few fixes #11714

<Do not review> pim6d: few fixes #11714

Conversation

mobash-rasool commented Aug 1, 2022

NetDEF-CI commented Aug 1, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Aug 16, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

NetDEF-CI commented Aug 16, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Aug 16, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Aug 18, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Aug 25, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Aug 26, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

NetDEF-CI commented Aug 29, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Aug 29, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Sep 14, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Sep 20, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

LabN-CI commented Sep 26, 2022 • edited Loading

Basic BGPD CI results: Partial FAILURE, 2 tests failed

NetDEF-CI commented Sep 26, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Oct 3, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

mobash-rasool commented Oct 4, 2022

NetDEF-CI commented Oct 4, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

github-actions bot commented Oct 13, 2022

github-actions bot commented Apr 12, 2023

NetDEF-CI commented Jun 28, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

NetDEF-CI commented Jun 28, 2023

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

mobash-rasool commented Oct 17, 2023

NetDEF-CI commented Aug 1, 2022 •

edited

Loading

NetDEF-CI commented Aug 16, 2022 •

edited

Loading

NetDEF-CI commented Aug 16, 2022 •

edited

Loading

NetDEF-CI commented Aug 16, 2022 •

edited

Loading

NetDEF-CI commented Aug 18, 2022 •

edited

Loading

NetDEF-CI commented Aug 25, 2022 •

edited

Loading

NetDEF-CI commented Aug 26, 2022 •

edited

Loading

NetDEF-CI commented Aug 29, 2022 •

edited

Loading

NetDEF-CI commented Aug 29, 2022 •

edited

Loading

NetDEF-CI commented Sep 14, 2022 •

edited

Loading

NetDEF-CI commented Sep 20, 2022 •

edited

Loading

LabN-CI commented Sep 26, 2022 •

edited

Loading

NetDEF-CI commented Sep 26, 2022 •

edited

Loading

NetDEF-CI commented Oct 3, 2022 •

edited

Loading

NetDEF-CI commented Oct 4, 2022 •

edited

Loading

NetDEF-CI commented Jun 28, 2023 •

edited

Loading