Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: Suppress HOB/STARVATION warnings when running in vtysh #14563

Merged

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented Oct 11, 2023

Running ping/traceroute/etc. (any kind of commands that use execute_command() suffer with this kind of warnings.

Related: #14412

Running ping/traceroute/etc. (any kind of commands that use execute_command()
suffer with this kind of warnings.

Signed-off-by: Donatas Abraitis <[email protected]>
Copy link
Member

@pguibert6WIND pguibert6WIND left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if I use an internal command ?
am I going to be still advertised by the warnings?
My expectation is that this event is only for external commands.
right?

@ton31337
Copy link
Member Author

Yes, only external commands, internal threads/commands are not involved.

@donaldsharp donaldsharp merged commit ac78d70 into FRRouting:master Oct 11, 2023
@ton31337 ton31337 deleted the fix/cpuwarning_starvation branch October 11, 2023 11:25
@donaldsharp
Copy link
Member

@Mergifyio backport dev/9.1

@mergify
Copy link

mergify bot commented Oct 11, 2023

backport dev/9.1

✅ Backports have been created

ton31337 added a commit that referenced this pull request Oct 12, 2023
lib: Suppress HOB/STARVATION warnings when running in vtysh (backport #14563)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants