Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zebra: add label chunk range in log when label manager request fails #14584

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

pguibert6WIND
Copy link
Member

@pguibert6WIND pguibert6WIND commented Oct 13, 2023

When the label manager is unable to provide a label chunk to a routing service, an error message is displayed:

Oct 11 11:47:27 vsr zebra[163745]: [YMY6E-K9JYD][EC 4043309085] Unable to assign Label Chunk [60;60] to bgp instance 0

There is missing information on the range that was requested. Add this information in the log message.

Oct 11 11:47:27 vsr zebra[163745]: [YMY6E-K9JYD][EC 4043309085] Unable to assign Label Chunk [60;60] to bgp instance 0

@frrbot frrbot bot added the zebra label Oct 13, 2023
@pguibert6WIND pguibert6WIND force-pushed the lmc_log_display_chunk branch 2 times, most recently from 2b2b1af to cc21c7b Compare October 13, 2023 08:33
@github-actions github-actions bot added size/M and removed size/S labels Oct 13, 2023
@pguibert6WIND pguibert6WIND force-pushed the lmc_log_display_chunk branch 2 times, most recently from db4f505 to e9ca514 Compare October 13, 2023 09:09
This function lm_get_chunk_response() is only called
by label_manager_get_chunk(). Let us move the code of
the function in the caller.

Signed-off-by: Philippe Guibert <[email protected]>
When the label manager is unable to provide a label chunk to
a routing service, an error message is displayed:

> Oct 11 11:47:27 vsr zebra[163745]: [YMY6E-K9JYD][EC 4043309085] Unable to assign Label Chunk to bgp instance 0

There is missing information on the range that was requested.
Add this information in the log message.

> Oct 11 11:47:27 vsr zebra[163745]: [YMY6E-K9JYD][EC 4043309085] Unable to assign Label Chunk 60 - 60 to bgp instance 0

Signed-off-by: Philippe Guibert <[email protected]>
@donaldsharp donaldsharp merged commit 4fa73b6 into FRRouting:master Oct 13, 2023
79 checks passed
@donaldsharp
Copy link
Member

@Mergifyio backport dev/9.1

@mergify
Copy link

mergify bot commented Oct 13, 2023

backport dev/9.1

✅ Backports have been created

donaldsharp added a commit that referenced this pull request Oct 13, 2023
zebra: add label chunk range in log when label manager request fails (backport #14584)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants