ospfd: avoid the redundant timers

[anlancs]

(config-router)# no summary-address 9.9.9.0/24
(config-router)# no summary-address 9.9.9.0/24
(config-router)# no summary-address 9.9.9.0/24
(config-router)# no summary-address 9.9.9.0/24
(config-router)# no summary-address 9.9.9.0/24

2025/01/09 09:30:10 OSPF: [S5BD4-3G5QX] ospf_external_aggr_timer: Start Aggregator delay timer 5(in seconds).
2025/01/09 09:30:11 OSPF: [S5BD4-3G5QX] ospf_external_aggr_timer: Start Aggregator delay timer 5(in seconds).
2025/01/09 09:30:11 OSPF: [S5BD4-3G5QX] ospf_external_aggr_timer: Start Aggregator delay timer 5(in seconds).
2025/01/09 09:30:11 OSPF: [S5BD4-3G5QX] ospf_external_aggr_timer: Start Aggregator delay timer 5(in seconds).
2025/01/09 09:30:12 OSPF: [S5BD4-3G5QX] ospf_external_aggr_timer: Start Aggregator delay timer 5(in seconds).

Since the timer thread for OSPF_ROUTE_AGGR_DEL has been created, the subsequent "no summary-address" commands shouldn't trigger redundant timers.

[mjstapp]

this is too general. why not add a clause for repeated AGGR_DEL like the one that's already present for AGGR_ADD?

[anlancs]

No. IMO "DEL" is not same to "ADD".
The continuous "DEL"s come, the first "DEL" should do the real thing: start timer and delete the item.

[mjstapp]

hmm - that's exactly what I wrote, but you said "no".
So: there's a clause for ADD that says "don't re-start the timer if it's already running for ADD". I suggest doing the same for DEL : if the timer is already running for DEL, emit a debug and don't reset the timer.

[anlancs]

I misunderstood your meaning just now.
I got your point, and re-pushed one. Thanks for your review.