Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua 5.4 support #17806

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Lua 5.4 support #17806

merged 3 commits into from
Jan 14, 2025

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented Jan 9, 2025

Closes #17787

@frrbot frrbot bot added the libfrr label Jan 9, 2025
@ton31337 ton31337 force-pushed the fix/lua5.4_support branch 2 times, most recently from 4a5ed4c to 686c0df Compare January 13, 2025 12:11
@ton31337 ton31337 force-pushed the fix/lua5.4_support branch 2 times, most recently from 95ba607 to 1fc0b80 Compare January 13, 2025 13:21
@ton31337 ton31337 marked this pull request as draft January 13, 2025 14:15
Signed-off-by: Donatas Abraitis <[email protected]>
lua_pcall() returns LUA_ERRGCMM in 5.3 which is already deprecated.

The constant LUA_ERRGCMM was removed.
Errors in finalizers are never propagated; instead, they generate a warning.

Signed-off-by: Donatas Abraitis <[email protected]>
@ton31337 ton31337 marked this pull request as ready for review January 13, 2025 16:45
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit fbea5ac into FRRouting:master Jan 14, 2025
11 checks passed
@ton31337 ton31337 deleted the fix/lua5.4_support branch January 14, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add support for lua 5.4
2 participants