Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support authlib-injector and display all part of skin #8

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Sciroccogti
Copy link

感谢 @Merrrg1n

@Fallen-Breath
Copy link
Owner

Are you able to maintain this part of code if pycraft upgrades and changes related codes in the future?

@Fallen-Breath
Copy link
Owner

The part of ClientSettingsPacket code is hard-coded, which is not good in my opinion. Things like client view distance or something will somehow affect the recording

@Sciroccogti
Copy link
Author

Are you able to maintain this part of code if pycraft upgrades and changes related codes in the future?

Sadly I'm not sure, but I'll try, so maybe you'd better not to merge into master. I just hope this branch may help those who are using PCRC with authlib-injector.

@Sciroccogti
Copy link
Author

The part of ClientSettingsPacket code is hard-coded, which is not good in my opinion. Things like client view distance or something will somehow affect the recording

Maybe it can be configured with conf.json? Currently I haven't seen any codes in PCRC to configure it, so I guess these parameters are set as default now. However I didn't find out which is the default value of view distance.

I'll try to make them editable as long as I have time.

@Sciroccogti
Copy link
Author

Test is REQUIRED before merging!

I tried to do some easy things on reading conf.json, but do not have a chance to test it since our server is paused (due to Graduate Entrance Exam). And I also cannot decide which setting should be added into the conf.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants