Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up most warnings #211

Merged
merged 3 commits into from
Dec 21, 2024
Merged

Cleaned up most warnings #211

merged 3 commits into from
Dec 21, 2024

Conversation

tristanpoland
Copy link
Member

This pull request is primarily focused on code cleanup, removal of unused imports, and addition of #[allow(dead_code, unused_variables)] attributes to suppress compiler warnings. The most important changes are summarized below:

Code Cleanup and Simplification:

  • Removed the definition of PLUGIN_API_VERSION in plugin_api/src/lib.rs as it was no longer needed.
  • Removed the serve import from server/src/server/mod.rs as it was unused.

Suppression of Compiler Warnings:

  • Added #[allow(dead_code, unused_variables)] attributes to several structs and functions in server/src/server/event_rep/structs.rs to suppress warnings about unused code. [1] [2] [3]
  • Added #[allow(dead_code, unused_variables)] attributes to the HorizonServer and HorizonThread structs and their methods in server/src/server/mod.rs to suppress warnings about unused code. [1] [2] [3] [4] [5]

Removal of Unused Imports:

  • Removed several unused imports from server/src/main.rs and server/src/server/config.rs to clean up the codebase. [1] [2]

Function Parameter Updates:

  • Updated the new method in plugins/chronos_plugin/src/lib.rs and plugins/player_lib/src/lib.rs to use _plugins instead of plugins to indicate that the parameter is intentionally unused. [1] [2]
  • Updated the setup_listeners function in plugins/player_lib/src/lib.rs to use _socket and _player instead of socket and player to indicate that the parameters are intentionally unused.

@tristanpoland tristanpoland merged commit d5962aa into main Dec 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant