-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue where the parser can read back old number state when parsing later numbers #1391
Conversation
pjfanning
commented
Jan 25, 2025
•
edited
Loading
edited
- new version of try to fix issue where _numberString is used despite having old value #1389 but targeted at 2.17 branch
- only the original test in test for issue #4917 jackson-databind#4918 is affected by the bug - similar tests (V2, V3, etc) are not affected.
- Aim is to use this fix for patch releases but to later try a bigger change to better manage number state in the parser code - in the 2.19 development branch
Ok that sounds reasonable. One reason why I think this fix is not ideal is that it actually does not clear the state unless value is accessed -- so it just covers this specific case and not others. But at the same it is somewhat minimal fix which is a plus for patch releases. |
Hmmmh. Playing with tests, the only fix that has any effect here is in I think I'll trim down changes slowly to parts that seem useful in general (namely, immediate return after "convertXxx()" calls). And then look into |
Merged all the way to Thank you for test & fix @pjfanning ! |