@JsonAnySetter on field annotation for Map #1249
Conversation
| AnnotatedField field = ((AnnotatedField) _setter); | ||
| // check whether the annotated field is an instance of Map, if | ||
| // not throw Error | ||
| if (!Map.class.isAssignableFrom(field.getRawType())) { |
There was a problem hiding this comment.
I think this should fail earlier, on construction (or perhaps introspection), no point in waiting until attempt is made to set it.
|
Yes, I think this is good at high level, so please go ahead with PR for I will add some notes on smaller tweaks (and one bigger question) for changes here -- thank you for this contribution too, very useful! |
| // we know it's a 2-arg method, second arg is the value | ||
| type = ((AnnotatedMethod) setter).getParameterType(1); | ||
| } else if (setter instanceof AnnotatedField) { | ||
| // get the type from the content type of the map object |
There was a problem hiding this comment.
This would be good place to verify that we got a Map valued property; type should then be MapType as well (and guarantee there is content type to use).
LokeshN
force-pushed
the
jsonanysetter-map
branch
from
f377459 to
91867e5
Compare
|
@cowtowncoder thanks for the review. I have made the corresponding changes and also submitted a new PR for jackson-annotations. |
LokeshN
force-pushed
the
jsonanysetter-map
branch
from
91867e5 to
a301960
Compare
Supporting @JsonAnySetter annotation on java.util.Map
LokeshN
force-pushed
the
jsonanysetter-map
branch
from
a301960 to
71f3907
Compare
|
@cowtowncoder I have made the changes accordingly and build is also passing now. |
|
@LokeshN Thank you again! I hope to review this again as soon as possible, and it should make it in 2.8.0 RC1 (i.e. won't release it without going over this PR). |
|
Excellent! Merged, will be in 2.8.0(.rc1) |
Supporting #1047 @JsonAnySetter annotation on java.util.Map field.
The build might fail for this PR since the @JsonAnySetter annotation is not enabled for the field in
jackson-annotations.
If the code changes are fine, then I will send a separate PR for @JsonAnySetter changes.
@cowtowncoder Let me know if the code changes are fine.