-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Coercion
fail message around Array
and Object
#3962
Fix Coercion
fail message around Array
and Object
#3962
Conversation
…ttps://github.com/JooHyukKim/jackson-databind into 3924-Incorrect-target-type-when-disabling-coercion
src/test/java/com/fasterxml/jackson/databind/convert/DisableCoercions3690Test.java
Show resolved
Hide resolved
src/main/java/com/fasterxml/jackson/databind/deser/std/StdDeserializer.java
Outdated
Show resolved
Hide resolved
src/test/java/com/fasterxml/jackson/databind/convert/DisableCoercions3690Test.java
Outdated
Show resolved
Hide resolved
Ok. So, after reading, re-reading things, I am not sure this is quite the way to fix the problem. The thing is that aside from "Scalar from Object" work-around needed for XML backend (failing for others including JSON), there is no coercion we would actually consider: we are just failing in general by calling So I think test change is good, but the fix should be much simpler: I'll add a note to point it. |
src/main/java/com/fasterxml/jackson/databind/deser/std/StdDeserializer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/fasterxml/jackson/databind/deser/std/StdDeserializer.java
Outdated
Show resolved
Hide resolved
Ok so I can't attach code review comment in place, so this line:
needs to be changed to, I think:
and that's the proper fix here. Plus change to call |
Coercion
fail message around Array
and Object
.Coercion
fail message around Array
and Object
resolves #3924