Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TypeIdResolvers serializable for Jackson 2.15 #4304

Merged
merged 6 commits into from
Jan 7, 2024
Merged

Make TypeIdResolvers serializable for Jackson 2.15 #4304

merged 6 commits into from
Jan 7, 2024

Conversation

JooHyukKim
Copy link
Member

@JooHyukKim JooHyukKim commented Jan 7, 2024 •
edited
Loading

resolves #4303
blocks #4305

@JooHyukKim JooHyukKim changed the title Make TypeIdResolvers serializable Make TypeIdResolvers serializable for Jackson 2.15 Jan 7, 2024
@JooHyukKim JooHyukKim mentioned this pull request Jan 7, 2024
Merged
@cowtowncoder
Copy link
Member

Should we really backport this into 2.15?

cowtowncoder
cowtowncoder reviewed Jan 7, 2024
View reviewed changes
...t/java/com/fasterxml/jackson/databind/jsontype/SerializablePolymorphicIdReaders4303Test.java Outdated
import static com.fasterxml.jackson.databind.BaseMapTest.newJsonMapper;

// [databind#4303]
class SerializablePolymorphicIdReaders4303Test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of new test class, let's instead add into com.fasterxml.jackson.databind.SerializeUsingJDKTest .

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there class named SerializeUsingJDKTest? couldn't find any

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May have been renamed, let me check what it was named in 2.15.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok yes, TestJDKSerialization. Renamed later on to be bit more descriptive.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found it, done via baf21e1, thanks!

@cowtowncoder
Copy link
Member

Ok, I guess it's fine to merge this in 2.15, after combining test cases into existing SerializeUsingJDKTest; and then proceeding with #4305.

@JooHyukKim
Copy link
Member Author

Should we really backport this into 2.15?

You think not, @cowtowncoder ?

I thought okay because "some of" IdResolvers can already be serialized 🤔

@cowtowncoder
Copy link
Member

Should we really backport this into 2.15?

You think not, @cowtowncoder ?

I thought okay because "some of" IdResolvers can already be serialized 🤔

Sorry. Should have thought it through... yes, it's fine esp. if some are other JDK serializable.

Apologies for noise.

@cowtowncoder cowtowncoder merged commit 12abf28 into FasterXML:2.15 Jan 7, 2024
4 checks passed
@cowtowncoder cowtowncoder added this to the 2.15.4 milestone Jan 7, 2024
@JooHyukKim JooHyukKim deleted the 4303-fix branch January 7, 2024 06:58
Philzen pushed a commit to Philzen/jackson-databind that referenced this pull request Apr 26, 2024
@JooHyukKim @Philzen
Make TypeIdResolvers serializable for Jackson 2.15 (FasterXML#4304)
7a6ac8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.15.4
Development

Successfully merging this pull request may close these issues.
2 participants
@JooHyukKim @cowtowncoder