Add test to verify fixing of #474 (for 2.13)

FasterXML · May 4, 2021 · ddf45b4 · ddf45b4
1 parent 8e722bb
commit ddf45b4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/release-notes/VERSION-2.x b/release-notes/VERSION-2.x
@@ -14,6 +14,9 @@ Project: jackson-dataformat-xml
  (reported by Fabian M)
 #465: ArrayIndexOutOfBoundsException in UTF8Reader (ossfuzz)
  (reported by Fabian M)
+#474: Empty String ("") parsed as 0 for int even if
+   DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES enabled (note:
+   actual fix in `jackson-databind)
 - Woodstox dependency 6.2.6 (from 6.2.4)
 
 2.12.4 (not yet released)

diff --git a/src/test/java/com/fasterxml/jackson/dataformat/xml/deser/EmptyWithScalarsTest.java b/src/test/java/com/fasterxml/jackson/dataformat/xml/deser/EmptyWithScalarsTest.java
@@ -3,6 +3,10 @@
 import java.math.BigDecimal;
 import java.math.BigInteger;
 
+import com.fasterxml.jackson.databind.DeserializationFeature;
+import com.fasterxml.jackson.databind.ObjectReader;
+import com.fasterxml.jackson.databind.exc.MismatchedInputException;
+
 import com.fasterxml.jackson.dataformat.xml.XmlMapper;
 import com.fasterxml.jackson.dataformat.xml.XmlTestBase;
 import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlRootElement;
@@ -72,7 +76,6 @@ public void testPrimitiveFPsWithEmpty() throws Exception
     // (will try to fix in 2.13, but not 2.12)
     public void testPrimitivesNoNulls() throws Exception
     {
-        /*
         ObjectReader r = MAPPER
                 .readerFor(NumbersPrimitive.class)
                 .with(DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES);
@@ -88,9 +91,8 @@ private void _testPrimitivesNoNulls(ObjectReader r, String doc) throws Exception
             r.readValue(_emptyWrapped("i"));
             fail("Should not pass");
         } catch (MismatchedInputException e) {
-            verifyException(e, "Cannot coerce empty String");
+            verifyException(e, "Cannot coerce `null` to ");
         }
-        */
     }
 
     /*