Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check added to prevent IonValue null deserialization to fail when bean has a missing property #322

Merged

Conversation

atokuzAmzn
Copy link
Contributor

This PR aims to resolve the issue #317
This is a duplicate of #320 which was created over 2.14.
This PR is created using 2.13 branch as base.

Changes:

  • Do not call getEmbeddedObject when current token is END_OBJECT
  • Add unit test case exposing the issue

@cowtowncoder
Copy link
Member

Happy to merge.

Just one last thing: @atokuzAmzn have I asked for and gotten a CLA for you? If not, it's a one-page doc from here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the usual method is to print it, fill & sign, scan/take photo, email to info at fasterxml dot com.
This only needs to be done once and CLA is good for all future use for all contributions to Jackson projects.
Apologies if I forgot that you have sent one (if so let me know).

With CLA I'll merge this ASAP and it will get in 2.13.3 release!

Thank you once again for going through the process & apologies for slowness on my part.

@atokuzAmzn
Copy link
Contributor Author

@cowtowncoder I have emailed the CLA to the info email.

@cowtowncoder
Copy link
Member

CLA clear now, will merge.

@cowtowncoder cowtowncoder merged commit c13fd35 into FasterXML:2.13 Apr 25, 2022
@cowtowncoder cowtowncoder modified the milestones: 2.10.0, 2.13.3 Apr 25, 2022
cowtowncoder added a commit that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants