Fix issue 458: Add null checking #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Chan <[email protected]>
cbor/src/main/java/com/fasterxml/jackson/dataformat/cbor/CBORParser.java
Outdated
Show resolved
Hide resolved
cowtowncoder
approved these changes
Jan 16, 2024
cbor/src/main/java/com/fasterxml/jackson/dataformat/cbor/CBORParser.java
Show resolved
Hide resolved
|
Thanks for showing me the details of the problematic part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #458 by adding a null check before accessing the length of the text string. This could avoid errors when getDecimalValue is invoked when there is no more data left in the input.