Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for issue #445: Wraps unexpected NullPointerException #446

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

arthurscchan
Copy link
Contributor

This PR provides a possible fix for issue #445 by adding a conditional check to ensure _cleanedTextValue is not null even if the input in invalid.

@cowtowncoder
Copy link
Member

@arthurscchan In the meantime, one process thing: have we gotten a CLA from you? (I am not 100% sure; please LMK if you have).
If not, it'd be from here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and is usually easiest to print, fill & sign, scan/photo, email to cla at fasterxml dot com.
This only needs to be done once before merging the first contribution; after that it's good for any and all contributions.

Looking forward to merging tests, fixes -- thank you for contributing these!

@cowtowncoder
Copy link
Member

@arthurscchan Thank you for providing the test! I was able to change the resolution slightly, figuring out that test triggers buffering and thereby the reason for missing _cleanedTextValue -- problems is that code was not using previously decoded int/long value but assuming buffered number String.

@cowtowncoder cowtowncoder merged commit 1e6f01d into FasterXML:2.17 Dec 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants