Wrap possible NullPointerException #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Chan <[email protected]>
cowtowncoder
reviewed
Dec 4, 2023
guava/src/main/java/com/fasterxml/jackson/datatype/guava/deser/GuavaCollectionDeserializer.java
Outdated
Show resolved
Hide resolved
cowtowncoder
reviewed
Dec 4, 2023
guava/src/main/java/com/fasterxml/jackson/datatype/guava/deser/GuavaCollectionDeserializer.java
Outdated
Show resolved
Hide resolved
|
if you added the null check why do you need the try-catch still? |
Signed-off-by: Arthur Chan <[email protected]>
|
@yawkat Thanks for your comments. They are two fixes in different packages. But I have changed the logic to have null check in both cases and added in unit test. |
cowtowncoder
reviewed
Dec 6, 2023
...in/java/com/fasterxml/jackson/datatype/guava/deser/GuavaImmutableCollectionDeserializer.java
Outdated
Show resolved
Hide resolved
cowtowncoder
approved these changes
Dec 6, 2023
|
Thank you @arthurscchan ! |
|
@arthurscchan I think that as per https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=64936 similar improvement(s) also needed for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a possible fix for issue #124 by adding null checking and wrapping possible NullPointerException thrown from underlying code or upstream libraries.