Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

fix for issue #48 #49

Merged
merged 1 commit into from
Jan 7, 2015
Merged

fix for issue #48 #49

merged 1 commit into from
Jan 7, 2015

Conversation

jwijgerd
Copy link
Contributor

@jwijgerd jwijgerd commented Jan 6, 2015

fix for issue #48

I am now either using the JsonSerializer that is passed in as a constructor property, if that is null the the BeanPropertyWriter.getSerializer() is used. This fixed the issue. I also added a testcase

fix for issue FasterXML#48 - reverted pom change of the annotations module version
@cowtowncoder
Copy link
Member

Makes sense, thanks you for reporting this and contributing the fix!

One formality we have to do is to get a CLA (unless we already have one -- apologies if I have asked for this before):

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and once provided I'll merge the fix, and CLA is good for any and all contributions for Jackson projects.

If you could print, fill, scan and email CLA to info at fasterxml dot com, that would be great. I can then merge the fix and it gets included in 2.5.1 release (plus I can backport it in 2.4 too assuming that's affected).

@jwijgerd
Copy link
Contributor Author

jwijgerd commented Jan 6, 2015

Hi Tatu,

Thanx, will check and sign it tomorrow. 2.4 is affected as well (in fact I
found it in 2.4.4 and fixed it there first). Would be much appreciated if
it could be included in 2.4.5

Thanx,

Joost
Op 6 jan. 2015 19:45 schreef "Tatu Saloranta" [email protected]:

Makes sense, thanks you for reporting this and contributing the fix!

One formality we have to do is to get a CLA (unless we already have one --
apologies if I have asked for this before):

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and once provided I'll merge the fix, and CLA is good for any and all
contributions for Jackson projects.

If you could print, fill, scan and email CLA to info at fasterxml dot
com, that would be great. I can then merge the fix and it gets included in
2.5.1 release (plus I can backport it in 2.4 too assuming that's affected).


Reply to this email directly or view it on GitHub
#49 (comment)
.

@cowtowncoder
Copy link
Member

Yup, I will backport it; we are getting enough bugs to soon qualify for 2.4.5 maintenance release.

cowtowncoder added a commit that referenced this pull request Jan 7, 2015
@cowtowncoder cowtowncoder merged commit 9fc3cf4 into FasterXML:master Jan 7, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants