Skip to content

Commit

Permalink
Move failing tests to tofix
Browse files Browse the repository at this point in the history
  • Loading branch information
JooHyukKim committed Jan 19, 2025
1 parent 4f44fd6 commit 10c7cdf
Show file tree
Hide file tree
Showing 11 changed files with 28 additions and 13 deletions.
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
package com.fasterxml.jackson.module.afterburner.failing;
package com.fasterxml.jackson.module.afterburner.tofix;

import java.io.*;

import org.junit.jupiter.api.Test;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.module.afterburner.AfterburnerTestBase;
import com.fasterxml.jackson.module.afterburner.util.failure.JacksonTestFailureExpected;

import static org.junit.jupiter.api.Assertions.*;

Expand All @@ -16,6 +17,7 @@ static class Point {
}

// But also test that after light use, ser/deser works
@JacksonTestFailureExpected
@Test
public void testMapperAfterUse() throws Exception
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.fasterxml.jackson.module.androidrecord.failing;
package com.fasterxml.jackson.module.androidrecord.tofix;

import org.junit.jupiter.api.Test;

Expand All @@ -9,6 +9,7 @@
import com.fasterxml.jackson.databind.*;
import com.fasterxml.jackson.module.androidrecord.BaseMapTest;
import com.fasterxml.jackson.module.androidrecord.RecordBasicsTest;
import com.fasterxml.jackson.module.androidrecord.testutil.failure.JacksonTestFailureExpected;

import static org.junit.jupiter.api.Assertions.fail;

Expand Down Expand Up @@ -45,6 +46,7 @@ public String name() {
*
* @see RecordBasicsTest#testDeserializeConstructorInjectRecord()
*/
@JacksonTestFailureExpected
@Test
public void testDeserializeHeaderInjectRecord_WillFail() throws Exception {
MAPPER.setInjectableValues(new InjectableValues.Std().addValue(String.class, "Bob"));
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.fasterxml.jackson.module.androidrecord.failing;
package com.fasterxml.jackson.module.androidrecord.tofix;

import org.junit.jupiter.api.Test;

Expand All @@ -11,6 +11,7 @@
import com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException;

import com.fasterxml.jackson.module.androidrecord.BaseMapTest;
import com.fasterxml.jackson.module.androidrecord.testutil.failure.JacksonTestFailureExpected;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.fail;
Expand Down Expand Up @@ -50,6 +51,7 @@ public RecordWithAltCtor(@JsonProperty("id") int id) {
*/

// Fails: Implicit canonical constructor still works too
@JacksonTestFailureExpected
@Test
public void testDeserializeWithAltCtor() throws Exception {
RecordWithAltCtor value = MAPPER.readValue("{\"id\":2812}",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.fasterxml.jackson.module.blackbird.failing;
package com.fasterxml.jackson.module.blackbird.tofix;

import java.io.ByteArrayOutputStream;
import java.io.InputStream;
Expand All @@ -8,6 +8,7 @@

import com.fasterxml.jackson.module.blackbird.BlackbirdTestBase;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.module.blackbird.testutil.failure.JacksonTestFailureExpected;

import static org.junit.jupiter.api.Assertions.*;

Expand All @@ -19,6 +20,7 @@ public class TestClassloaders extends BlackbirdTestBase

// Note: this test always passes in Java 8, even if the issue is not fixed,
// so it is duplicated in jackson-jdk11-compat-test for now
@JacksonTestFailureExpected
@Test
public void testLoadInChildClassloader() throws Exception {
TestLoader loader = new TestLoader(getClass().getClassLoader());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import com.fasterxml.jackson.module.jakarta.xmlbind.JakartaXmlBindAnnotationIntrospector;

import com.fasterxml.jackson.module.jakarta.xmlbind.ModuleTestBase;
import com.fasterxml.jackson.module.jakarta.xmlbind.testutil.failure.JacksonTestFailureExpected;

import static org.junit.jupiter.api.Assertions.*;

Expand Down Expand Up @@ -57,6 +58,7 @@ public B(String type) {
*/

// not asserting anything
@JacksonTestFailureExpected
@Test
public void testXmlElementAndXmlElementRefs() throws Exception
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import com.fasterxml.jackson.databind.ObjectMapper;

import com.fasterxml.jackson.module.jakarta.xmlbind.ModuleTestBase;
import com.fasterxml.jackson.module.jakarta.xmlbind.testutil.failure.JacksonTestFailureExpected;

import static org.junit.jupiter.api.Assertions.*;

Expand Down Expand Up @@ -50,6 +51,7 @@ static class HasIDList
public HasID getParent() { return parent; }
}

@JacksonTestFailureExpected
@Test
public void testIssue46() throws Exception
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.fasterxml.jackson.module.jaxb.failing;
package com.fasterxml.jackson.module.jaxb.tofix;

import javax.xml.bind.annotation.*;
import javax.xml.bind.annotation.adapters.*;
Expand All @@ -7,6 +7,7 @@

import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.module.jaxb.BaseJaxbTest;
import com.fasterxml.jackson.module.jaxb.testutil.failure.JacksonTestFailureExpected;

import static org.junit.jupiter.api.Assertions.*;

Expand Down Expand Up @@ -44,6 +45,7 @@ public enum Code {
private final ObjectMapper MAPPER = getJaxbMapper();

// [modules-base#256]
@JacksonTestFailureExpected
@Test
public void testEnumSerialize256() throws Exception
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.fasterxml.jackson.module.jaxb.failing;
package com.fasterxml.jackson.module.jaxb.tofix;

import javax.xml.bind.annotation.*;

Expand All @@ -10,6 +10,7 @@
import com.fasterxml.jackson.databind.introspect.JacksonAnnotationIntrospector;
import com.fasterxml.jackson.module.jaxb.BaseJaxbTest;
import com.fasterxml.jackson.module.jaxb.JaxbAnnotationIntrospector;
import com.fasterxml.jackson.module.jaxb.testutil.failure.JacksonTestFailureExpected;

import static org.junit.jupiter.api.Assertions.*;

Expand Down Expand Up @@ -55,6 +56,7 @@ public B(String type) {
*/

// not asserting anything
@JacksonTestFailureExpected
@Test
public void testXmlElementAndXmlElementRefs() throws Exception
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.fasterxml.jackson.module.jaxb.failing;
package com.fasterxml.jackson.module.jaxb.tofix;

import java.util.Arrays;
import java.util.List;
Expand All @@ -10,6 +10,7 @@

import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.module.jaxb.BaseJaxbTest;
import com.fasterxml.jackson.module.jaxb.testutil.failure.JacksonTestFailureExpected;

import static org.junit.jupiter.api.Assertions.*;

Expand Down Expand Up @@ -49,6 +50,7 @@ static class HasIDList
public HasID getParent() { return parent; }
}

@JacksonTestFailureExpected
@Test
public void testIssue46() throws Exception
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.fasterxml.jackson.module.paranamer.failing;
package com.fasterxml.jackson.module.paranamer.tofix;

import org.junit.jupiter.api.Test;

Expand All @@ -7,6 +7,7 @@
import com.fasterxml.jackson.databind.PropertyNamingStrategies;
import com.fasterxml.jackson.module.paranamer.ParanamerModule;
import com.fasterxml.jackson.module.paranamer.ModuleTestBase;
import com.fasterxml.jackson.module.paranamer.testutil.failure.JacksonTestFailureExpected;

import static org.junit.jupiter.api.Assertions.*;

Expand Down Expand Up @@ -40,6 +41,7 @@ public static StaticStringCreatorBean parse(String delimited)
.registerModule(new ParanamerModule())
.setPropertyNamingStrategy(PropertyNamingStrategies.UPPER_CAMEL_CASE);

@JacksonTestFailureExpected
@Test
public void testStaticStringCreator() throws Exception
{
Expand Down
5 changes: 0 additions & 5 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,6 @@ not datatype, data format, or JAX-RS provider modules.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<excludes>
<exclude>com/fasterxml/jackson/**/failing/*.java</exclude>
</excludes>
</configuration>
</plugin>
</plugins>
</pluginManagement>
Expand Down

0 comments on commit 10c7cdf

Please sign in to comment.