Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fastly_exporter to 9.0.0 #49

Closed
wants to merge 1 commit into from
Closed

Conversation

github-actions[bot]
Copy link

Update fastly_exporter to 9.0.0.

What's Changed

Breaking Changes 🛠

The exporter maps bucketed counters from the real-time stats API to a Prometheus histogram. Since it doesn't have the actual values that were used to build the bucketed counters it has to pick a value for each bucket to call Observe() with.

The current code uses values that are mapping to the wrong buckets. Here's a subset of the buckets from the origin latency histogram definition: 0.001, 0.005, 0.010

Calling Observe() with the value of 0.005 places the value in the 1-5ms bucket, not the 5-10ms bucket. The result of the previous behavior is that the counts for each bucket are shifted to the next smallest bucket.

This fixes the issue by using the values at the end of each bucket interval as the parameters to Observe().

This will result in a perceived increase in origin latency values when users upgrade to the release, but the increased numbers are more accurate.

New Contributors

Full Changelog: fastly/fastly-exporter@v8.1.0...v9.0.0

@Firefishy Firefishy closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant