bored...

EtLast.CommandService/CommandService.RunTask.cs

@@ -35,18 +35,33 @@ protected override IExecutionResult RunTasks(string commandId, string moduleName
             Tasks = tasks.ToArray(),
         };
 
-        startup?.Invoke(sessionBuilder, arguments);
-
         foreach (var configurator in SessionConfigurators)
             configurator?.Invoke(sessionBuilder, arguments);
 
+        startup?.Invoke(sessionBuilder, arguments);
+
         if (moduleName != null)
             context.Manifest.Extra["ModuleName"] = moduleName;
 
         context.Manifest.Extra["TaskNames"] = tasks.Select(x => x.GetType().GetFriendlyTypeName()).ToArray();
 
-        foreach (var manifestProcessor in sessionBuilder.ManifestProcessors)
-            manifestProcessor?.RegisterToManifestEvents(context, context.Manifest);
+        if (sessionBuilder.ManifestProcessorCreators?.Count > 0)
+        {
+            try
+            {
+                foreach (var creator in sessionBuilder.ManifestProcessorCreators)
+                {
+                    var manifestProcessor = creator?.Invoke();
+                    manifestProcessor?.RegisterToManifestEvents(context, context.Manifest);
+                }
+            }
+            catch (Exception ex)
+            {
+                var formattedMessage = ex.Format();
+                context.Log(LogSeverity.Error, null, "{ErrorMessage}", formattedMessage);
+                context.LogOps(LogSeverity.Error, null, "{ErrorMessage}", formattedMessage);
+            }
+        }
 
         if (sessionBuilder.EtlContextLoggerCreators?.Count > 0)
         {
@@ -64,7 +79,7 @@ protected override IExecutionResult RunTasks(string commandId, string moduleName
             }
             catch (Exception ex)
             {
-                var formattedMessage = ex.FormatWithEtlDetails();
+                var formattedMessage = ex.Format();
                 context.Log(LogSeverity.Error, null, "{ErrorMessage}", formattedMessage);
                 context.LogOps(LogSeverity.Error, null, "{ErrorMessage}", formattedMessage);
             }

EtLast.CommandService/SessionBuilderFluent.cs

@@ -8,7 +8,7 @@ public static ISessionBuilder UseRollingDevLogManifestFiles(this ISessionBuilder
         var directory = Path.Combine(session.DevLogDirectory, "manifest");
         CleanupManifestDirectory(maxFileCount, maxSizeOnDisk, directory);
 
-        return session.AddManifestProcessor(new CommandServiceJsonManifestProcessor()
+        return session.AddManifestProcessor(() => new CommandServiceJsonManifestProcessor()
         {
             Directory = directory,
             FileNameGenerator = manifest => manifest.ContextId.ToString("D", CultureInfo.InvariantCulture) + ".json",

EtLast.Hosting/Logging/EtlContextConsoleLogger.cs

@@ -1,6 +1,6 @@
 namespace FizzCode.EtLast;
 
-internal class EtlContextConsoleLogger : IEtlContextListener
+internal class EtlContextConsoleLogger : IEtlContextLogger
 {
     private readonly ILogger _logger;
 
@@ -84,34 +84,6 @@ public void OnContextIoCommandEnd(IoCommand ioCommand)
     {
     }
 
-    public void OnRowCreated(IReadOnlyRow row)
-    {
-    }
-
-    public void OnRowOwnerChanged(IReadOnlyRow row, IProcess previousProcess, IProcess currentProcess)
-    {
-    }
-
-    public void OnRowValueChanged(IReadOnlyRow row, params KeyValuePair<string, object>[] values)
-    {
-    }
-
-    public void OnSinkStarted(IProcess process, Sink sink)
-    {
-    }
-
-    public void OnWriteToSink(Sink sink, IReadOnlyRow row)
-    {
-    }
-
-    public void OnProcessStart(IProcess process)
-    {
-    }
-
-    public void OnProcessEnd(IProcess process)
-    {
-    }
-
     public void OnContextClosed()
     {
         try
@@ -127,7 +99,7 @@ public static class EtlContextConsoleLoggerFluent
 {
     public static ISessionBuilder LogToConsole(this ISessionBuilder builder, LogSeverity minimumLogLevel = LogSeverity.Information)
     {
-        builder.Context.Listeners.Add(new EtlContextConsoleLogger(builder.Context, minimumLogLevel));
+        builder.Context.Loggers.Add(new EtlContextConsoleLogger(builder.Context, minimumLogLevel));
         return builder;
     }
 }

EtLast.Hosting/Logging/EtlContextDevToFileLogger.cs

@@ -304,7 +304,7 @@ public static class EtlContextDevToFileLoggerFluent
 {
     public static ISessionBuilder LogDevToFile(this ISessionBuilder builder, LogSeverity minimumLogLevel = LogSeverity.Debug, int retentionHours = 24 * 31)
     {
-        builder.AddLoggerCreator(() => new EtlContextDevToFileLogger(builder.Context, builder.DevLogDirectory, minimumLogLevel, retentionHours));
+        builder.AddLogger(() => new EtlContextDevToFileLogger(builder.Context, builder.DevLogDirectory, minimumLogLevel, retentionHours));
         return builder;
     }
 }

EtLast.Hosting/Logging/EtlContextDevToSeqLogger.cs

@@ -98,7 +98,7 @@ public static class EtlContextDevToSeqLoggerFluent
 {
     public static ISessionBuilder LogDevToSeq(this ISessionBuilder session, string url, string apiKey, LogSeverity minimumLogLevel = LogSeverity.Debug)
     {
-        session.AddLoggerCreator(() => new EtlContextDevToSeqLogger(session.Context, url, apiKey, minimumLogLevel));
+        session.AddLogger(() => new EtlContextDevToSeqLogger(session.Context, url, apiKey, minimumLogLevel));
         return session;
     }
 }

EtLast.Hosting/Logging/EtlContextOpsToFileLogger.cs

@@ -188,7 +188,7 @@ public static class EtlContextOpsToFileLoggerFluent
 {
     public static ISessionBuilder LogOpsToFile(this ISessionBuilder session, int importantFileCount = 30, int infoFileCount = 14)
     {
-        session.AddLoggerCreator(() => new EtlContextOpsToFileLogger(session.Context, session.OpsLogDirectory, importantFileCount, infoFileCount));
+        session.AddLogger(() => new EtlContextOpsToFileLogger(session.Context, session.OpsLogDirectory, importantFileCount, infoFileCount));
         return session;
     }
 }

EtLast/Session/ISessionBuilder.cs

@@ -9,7 +9,7 @@ public interface ISessionBuilder
     public string DevLogDirectory { get; }
     public string OpsLogDirectory { get; }
 
-    public ISessionBuilder AddManifestProcessor(IManifestProcessor manifestProcessor);
-    public ISessionBuilder AddLoggerCreator(Func<IEtlContextLogger> creator);
+    public ISessionBuilder AddManifestProcessor(Func<IManifestProcessor> manifestProcessor);
+    public ISessionBuilder AddLogger(Func<IEtlContextLogger> creator);
     public ISessionBuilder UseTransactionScopeTimeout(TimeSpan timeout);
 }

EtLast/Session/SessionBuilder.cs

@@ -8,18 +8,18 @@ public class SessionBuilder : ISessionBuilder
     public required string DevLogDirectory { get; init; }
     public required string OpsLogDirectory { get; init; }
 
-    public List<IManifestProcessor> ManifestProcessors { get; } = [];
+    public List<Func<IManifestProcessor>> ManifestProcessorCreators { get; } = [];
 
     [EditorBrowsable(EditorBrowsableState.Never)]
     public List<Func<IEtlContextLogger>> EtlContextLoggerCreators { get; } = [];
 
-    public ISessionBuilder AddManifestProcessor(IManifestProcessor manifestProcessor)
+    public ISessionBuilder AddManifestProcessor(Func<IManifestProcessor> manifestProcessor)
     {
-        ManifestProcessors.Add(manifestProcessor);
+        ManifestProcessorCreators.Add(manifestProcessor);
         return this;
     }
 
-    public ISessionBuilder AddLoggerCreator(Func<IEtlContextLogger> creator)
+    public ISessionBuilder AddLogger(Func<IEtlContextLogger> creator)
     {
         EtlContextLoggerCreators.Add(creator);
         return this;

EtLast/Telemetry/ContextManifest/IManifestProcessor.cs

@@ -3,4 +3,4 @@
 public interface IManifestProcessor
 {
     public void RegisterToManifestEvents(IEtlContext context, ContextManifest manifest);
-}
+}