Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: send push notifications #188

Closed
wants to merge 23 commits into from
Closed

feat: send push notifications #188

wants to merge 23 commits into from

Conversation

FleetAdmiralJakob
Copy link
Owner

@FleetAdmiralJakob FleetAdmiralJakob commented Jun 4, 2024 •
edited
Loading

Fixes: #183

@vercel Vercel
Copy link

vercel bot commented Jun 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chat-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 7:26am

@socket-security Socket Security
Copy link

socket-security bot commented Jun 4, 2024 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None 0 14.9 kB types
npm/[email protected] None 0 424 kB hirokiosame
npm/[email protected] network 0 48.2 kB marco-c

View full report↗︎

@FleetAdmiralJakob
Merge branch 'refs/heads/main' into notifications
76b850b 
# Conflicts:
#	package.json
#	pnpm-lock.yaml
#	src/lib/utils.ts
#	src/sw.ts
@FleetAdmiralJakob
fix: fixed broken package-lock
d1d0abd
@socket-security Socket Security
Copy link

socket-security bot commented Jun 22, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@FleetAdmiralJakob
Copy link
Owner Author

FleetAdmiralJakob commented Jun 23, 2024 •
edited
Loading

Problems that needs to be resolved:

  • Does not work on mobile

- Does not work if browser is closed: serwist/serwist#153 (reply in thread) <-- This is not implemented in the browsers. You can only receive the notifications if the browser is open.

@FleetAdmiralJakob
Copy link
Owner Author

If there is no fix for some common issues with PWAs, Serwist and Turbopack in the future, I see no future in this feature, maybe with a native app.

@FleetAdmiralJakob FleetAdmiralJakob deleted the notifications branch November 25, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notifications
2 participants
@FleetAdmiralJakob @jakoblylu