Add all supported API Fields in Movie Add to List Dialog #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DB search based on existing IMDB_ID
Adding `year` field that will be forwarded to the API call
Merge Main repo
Change attribute to optional for EntryFields Co-Authored-By: Kristen Mills <[email protected]>
…m TMDB For Movie entry display "Original Title" beside the Title when it exist and is different Useful for non English movies with an existing title in local language
Add year input field in Movie Add Dialog
Creating a new structurte for optionnal Properties Adding IMDB_ID & TMDB_ID as they are already support by the API
…itle from TMDB" This reverts commit d9c18fd.
Codecov Report
@@ Coverage Diff @@
## develop #110 +/- ##
===========================================
+ Coverage 90.72% 90.74% +0.01%
===========================================
Files 128 128
Lines 2738 2743 +5
Branches 439 442 +3
===========================================
+ Hits 2484 2489 +5
Misses 250 250
Partials 4 4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
When adding movie from WebUI you can only specify the title.
API call currently support:
Adding year help accuracy for matching the correct movie
Adding movie ID from IMDB or TMDB allow an exact match
Detailed changes:
addEntryOptionalPropsas they are optionalEntryFieldsto support new needed fieldsaddEntryOptionalPropsin the DialogAddressed issues:
Movie Yearfield as an optional field as you recent with recent change you can not add a movie without ayearbecause all entries are initialized to''To Do: