-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a randi() function to generate random integers #124
Added a randi() function to generate random integers #124
Conversation
Hi @FlorianRappl, I'm not that well versed in C#, it would be great if you could have a look. Thanks! |
The build script is not running correctly. It tries to copy files from a directory named |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - only the Randi
definition needs to consider currying and the arguments.
It is broken for a longer time - I had no time to fix it until now. The problem is a bit more complex than that - there are some things which require one framework but won't work in another etc. - to fix it certain dependencies need to be replaced. |
Hi @FlorianRappl, can we backport this feature into a v2.x release? If yes, what could be the timeline for the same? If no, how should we proceed further? This PR is associated with an issue in the Powertoys repo as well linked here. |
Theoretically yes but the build failure is not related to v3, but rather to the build agent. As such there won't be a successful build with V2 either. I can have a look but it will take some time as this project is currently not sponsored and therefore without priority. |
Surely @FlorianRappl, can you provide some rough ETA for the same? |
Types of Changes
Addition of a
randi()
function to generate random integers, accepting an argument, let's saymax
. The generated number is 0 <generated_value
<=max
Prerequisites
Please make sure you can check the following two boxes:
Contribution Type
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Description
Added a function to generate random integers. This PR closes #123