Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM64 Build #2985

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from
Open
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file not shown.

Unchanged files with check annotations Beta

var t = await MemoryPackSerializer.DeserializeAsync<T>(stream);
return t;
}
catch (System.Exception e)

Check warning on line 68 in Flow.Launcher.Infrastructure/Storage/BinaryStorage.cs

GitHub Actions / build

The variable 'e' is declared but never used
{
// Log.Exception($"|BinaryStorage.Deserialize|Deserialize error for file <{FilePath}>", e);
return defaultData;
});
}
public static async Task Save()

Check warning on line 63 in Flow.Launcher.Infrastructure/Image/ImageLoader.cs

GitHub Actions / build

Use "Async" suffix in names of methods that return an awaitable type (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD200.md)
{
await storageLock.WaitAsync();
private void OnWinRPressed()
{
// show the main window and set focus to the query box
Task.Run(() =>

Check warning on line 372 in Plugins/Flow.Launcher.Plugin.Shell/Main.cs

GitHub Actions / build

Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)
{
context.API.ShowMainWindow();
context.API.ChangeQuery($"{context.CurrentPluginMetadata.ActionKeywords[0]}{Plugin.Query.TermSeparator}");
new()
{
Title = context.API.GetTranslation("flowlauncher_plugin_cmd_run_as_different_user"),
AsyncAction = async c =>

Check warning on line 402 in Plugins/Flow.Launcher.Plugin.Shell/Main.cs

GitHub Actions / build

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
{
Execute(ShellCommand.RunAsDifferentUser, PrepareProcessStartInfo(selectedResult.Title));
return true;
/// </summary>
internal abstract class JsonRPCPlugin : JsonRPCPluginBase
{
public const string JsonRPC = "JsonRPC";

Check warning on line 35 in Flow.Launcher.Core/Plugin/JsonRPCPlugin.cs

GitHub Actions / build

'JsonRPCPlugin.JsonRPC' hides inherited member 'JsonRPCPluginBase.JsonRPC'. Use the new keyword if hiding was intended.
protected abstract Task<Stream> RequestAsync(JsonRPCRequestModel rpcRequest, CancellationToken token = default);
protected abstract string Request(JsonRPCRequestModel rpcRequest, CancellationToken token = default);
{
public class JsonRPCPluginSettings
{
public required JsonRpcConfigurationModel? Configuration { get; init; }

Check warning on line 14 in Flow.Launcher.Core/Plugin/JsonRPCPluginSettings.cs

GitHub Actions / build

The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
public required string SettingPath { get; init; }
public Dictionary<string, FrameworkElement> SettingControls { get; } = new();
var latest = releases.Where(r => !r.Prerelease).OrderByDescending(r => r.PublishedAt).First();
var latestUrl = latest.HtmlUrl.Replace("/tag/", "/download/");
var client = new WebClient

Check warning on line 133 in Flow.Launcher.Core/Updater.cs

GitHub Actions / build

'WebClient.WebClient()' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead.' (https://aka.ms/dotnet-warnings/SYSLIB0014)
{
Proxy = Http.WebProxy
};
public override async Task ReloadDataAsync()
{
var oldProcess = ClientProcess;
ClientProcess = Process.Start(StartInfo);

Check warning on line 73 in Flow.Launcher.Core/Plugin/ProcessStreamPluginV2.cs

GitHub Actions / build

Possible null reference assignment.
ArgumentNullException.ThrowIfNull(ClientProcess);
SetupPipe(ClientProcess);
await base.ReloadDataAsync();
{
await RPC.InvokeAsync("close");
}
catch (RemoteMethodNotFoundException e)

Check warning on line 148 in Flow.Launcher.Core/Plugin/JsonRPCPluginV2.cs

GitHub Actions / build

The variable 'e' is declared but never used
{
}
finally
{
FilesFolders.RemoveFolderIfExists(InstallPath);
DroplexPackage.Drop(App.nodejs_16_18_0, InstallPath).Wait();

Check warning on line 30 in Flow.Launcher.Core/ExternalPlugins/Environments/TypeScriptV2Environment.cs

GitHub Actions / build

Synchronously waiting on tasks or awaiters may cause deadlocks. Use await or JoinableTaskFactory.Run instead. (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD002.md)
PluginsSettingsFilePath = ExecutablePath;
}