Added popover scaffold (Resolves #19) #20
Conversation
… messing with one of our tests - need to fix.
|
@angelosilvestre if you pull down this PR, uncomment the commented code in the tap region ID test, and run that test on the latest Flutter stable, does your machine blow up with a segmentation fault? |
|
@matthew-carroll On the master channel I'm getting this crash: 00:01 +19: /Users/angelosilvestre/dev/overlord/test/menus/popover_test.dart: PopoverScaffold does not close popover when tapping a widget with the same tap region groupId (on Android) Shell: [ERROR:flutter/impeller/runtime_stage/runtime_stage.cc(27)] Reached unreachable code.
unhandled error during finalization of test:
/Users/angelosilvestre/dev/overlord/test/menus/popover_test.dart
TestDeviceException(Shell subprocess crashed with SIGABRT (-6).)
#0 FlutterTesterTestDevice.finished (package:flutter_tools/src/test/flutter_tester_device.dart:248:5)
<asynchronous suspension>
#1 FlutterTesterTestDevice.kill (package:flutter_tools/src/test/flutter_tester_device.dart:230:5)
<asynchronous suspension>
#2 FlutterPlatform._startTest.<anonymous closure> (package:flutter_tools/src/test/flutter_platform.dart:525:9)
<asynchronous suspension>
#3 FlutterPlatform._startTest (package:flutter_tools/src/test/flutter_platform.dart:581:11)
<asynchronous suspension> |
|
@angelosilvestre what about Stable? |
|
@matthew-carroll This isn't happening on master here. |
|
@matthew-carroll This crash is also happening in some super_editor tests. |
|
@angelosilvestre does this happen to you when you run it on Stable? |
|
EDIT:
It should be "This isn't happening on stable here." |
|
Are you using the latest stable from about a week ago? |
|
@matthew-carroll I just updated to the latest stable. |
|
....and? |
|
On the latest stable the issue doesn't happen, but it happen on the latest master |
|
Hm, seems like it's working for me on Stable now. I thought it was blowing up. Have you seen any issue for this logged with Flutter? |
|
@angelosilvestre were there any other comments on this PR? Did I miss anything? |
Added popover scaffold (Resolves #19)
This scaffold was migrated and modified from Super Editor.
This PR also includes some multi-level menu work, though that work isn't the focus of this PR. I'd like to merge the scaffold for dropdown lists and then continue to polish the multi-level menu use-case.
Screen.Recording.2024-02-15.at.12.00.21.AM.mov
Screen.Recording.2024-02-15.at.12.01.21.AM.mov