Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accum genfunc error on nightly #1463

Closed
wants to merge 2 commits into from
Closed

Fix accum genfunc error on nightly #1463

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e347246
Fix `accum` genfunc error on nightly
ToucheSir Oct 11, 2023
cc8aeee
Use `typeof`
ToucheSir Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/lib/lib.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ accum(x::AbstractArray, ys::AbstractArray...) = accum.(x, ys...)

@generated function accum(x::NamedTuple, y::NamedTuple)
# assumes that y has no keys apart from those also in x
fieldnames(y) ⊆ fieldnames(x) || throw(ArgumentError("$y keys must be a subset of $x keys"))
if fieldnames(y) ⊈ fieldnames(x)
return :(throw(ArgumentError("$(typeof(y)) keys must be a subset of $(typeof(x)) keys")))
end

grad(field) = field in fieldnames(y) ? :(y.$field) : :nothing
Expr(:tuple, [:($f=accum(x.$f, $(grad(f)))) for f in fieldnames(x)]...)
Expand Down