Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @adjoints for sort and filter #1493

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

lkdvos
Copy link
Contributor

@lkdvos lkdvos commented Jan 3, 2024

This removes the definitions of sort and filter, as these are covered by ChainRules.
This also fixes #1492 , as the ChainRules rrule for sort includes all keywords.

@devmotion
Copy link
Collaborator

This also fixes #1492 , as the ChainRules rrule for sort includes all keywords.

I think it would be good to add a test for #1492.

@darsnack
Copy link
Member

darsnack commented Jan 3, 2024

The Molly.jl failure seems real, but the downstream test set is complex/foreign enough that I can't decipher where sort or filter are used. @jgreener64 can you confirm that this change is causing the failures and where?

@jgreener64
Copy link
Contributor

That test does fail sometimes due to stochasticity, I should improve it. The Molly CI run for the latest commit seems fine though, so this change doesn't seem to break anything.

@lkdvos
Copy link
Contributor Author

lkdvos commented Jan 4, 2024

I think in that case this is ready for review + merge, unless I need to add something else?

@darsnack darsnack merged commit 9df7226 into FluxML:master Jan 4, 2024
10 of 13 checks passed
@lkdvos lkdvos deleted the ld/sort branch January 4, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sort(x; rev=true) is not supported
4 participants