Add literature background to dataloder-image-data and mlp-mnist #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToucheSir
reviewed
Mar 18, 2022
| train_x, train_y = MNIST.traindata(Float32) | ||
| test_x, test_y = MNIST.testdata(Float32) | ||
|
|
||
| # Reshape data to 28x28x1 multi-dimensional array | ||
| ## Reshape data to 28x28x1 multi-dimensional array |
There was a problem hiding this comment.
Question about the double ##: are these going to be used for some kind of literate rendered output later?
There was a problem hiding this comment.
@ToucheSir that's right, we are adding these so we can use Literate to convert the file to markdown and notebooks
ToucheSir
approved these changes
Mar 21, 2022
|
@ToucheSir this is ready for merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds literature background to the following:
Issue # 340