Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release PR #528

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Release PR #528

wants to merge 19 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 19, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

@forgerock/[email protected]

Minor Changes

Patch Changes

  • #527 5119dc0 Thanks @cerebrl! - In order to display a more user-friendly name when saving a WebAuthn/Passkey device to an account, we prioritized displayName over userName for assignment to the name property of the WebAuthn options object. This avoids the display of UUIDs for saved credentials.

@forgerock/[email protected]

Patch Changes

@forgerock/[email protected]

Patch Changes

@forgerock/[email protected]

Patch Changes

Security: - Proxy config declaring URLs is now required and will be used to generate an allow list of origins to check again prior to fowarding a request.

ryanbas21 and others added 10 commits December 11, 2024 16:22
fix doc generation commands
add codecov, fix up tsconfigs, and add extenssions to mock-api-v2 for
node16+ support
added a `contributing-docs` folder. This is because
the `docs` folder is `.gitignored` for `typedoc` builds.
- this uses `displayName || userName` for assignment to the `name`
  attribute of the WebAuthn options object
- This allows for a more readable value for when WebAuthn device is
  saved
fix(javascript-sdk): prioritize displayName for WebAuthn name attribute
Copy link

nx-cloud bot commented Jan 13, 2025

View your CI Pipeline Execution ↗ for commit bcb9eeb.

Command Status Duration Result
nx affected -t build lint test docs e2e-ci --ve... ✅ Succeeded 4m 24s View ↗
nx-cloud record -- nx format:check --verbose ✅ Succeeded 8s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-13 19:35:30 UTC

@ryanbas21 ryanbas21 force-pushed the changeset-release/master branch 3 times, most recently from e3b3f36 to bcb9eeb Compare January 13, 2025 19:28
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@210d647). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/device-client/src/lib/device.store.ts 0.00% 2 Missing ⚠️
packages/javascript-sdk/src/fr-webauthn/index.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #528   +/-   ##
=========================================
  Coverage          ?   57.24%           
=========================================
  Files             ?      123           
  Lines             ?    26967           
  Branches          ?     1718           
=========================================
  Hits              ?    15438           
  Misses            ?    11529           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

forgerock-chris and others added 3 commits January 21, 2025 17:14
adds device client to the SDK package
docs: update Backstage links in README files (SDKS-3707)
@github-actions github-actions bot force-pushed the changeset-release/master branch from bcb9eeb to 9b06082 Compare January 23, 2025 11:43
ryanbas21 and others added 3 commits January 24, 2025 12:53
fix types, add tests, fix tests, fix manual e2e
renamed all per comments to better fit naming schemes
@github-actions github-actions bot force-pushed the changeset-release/master branch from 9b06082 to aa8c074 Compare January 27, 2025 16:01
updates vite per mend scan and update nx per trying to update vite
@github-actions github-actions bot force-pushed the changeset-release/master branch from aa8c074 to 8ffe4e8 Compare January 27, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants