-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release PR #528
Open
github-actions
wants to merge
19
commits into
master
Choose a base branch
from
changeset-release/master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release PR #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix doc generation commands
add codecov, fix up tsconfigs, and add extenssions to mock-api-v2 for node16+ support
added a `contributing-docs` folder. This is because the `docs` folder is `.gitignored` for `typedoc` builds.
docs: update-contributing-docs
chore: automate-docs
- this uses `displayName || userName` for assignment to the `name` attribute of the WebAuthn options object - This allows for a more readable value for when WebAuthn device is saved
fix(javascript-sdk): prioritize displayName for WebAuthn name attribute
View your CI Pipeline Execution ↗ for commit bcb9eeb.
☁️ Nx Cloud last updated this comment at |
ryanbas21
force-pushed
the
changeset-release/master
branch
3 times, most recently
from
January 13, 2025 19:28
e3b3f36
to
bcb9eeb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #528 +/- ##
=========================================
Coverage ? 57.24%
=========================================
Files ? 123
Lines ? 26967
Branches ? 1718
=========================================
Hits ? 15438
Misses ? 11529
Partials ? 0 ☔ View full report in Codecov by Sentry. |
adds device client to the SDK package
docs: update Backstage links in README files (SDKS-3707)
github-actions
bot
force-pushed
the
changeset-release/master
branch
from
January 23, 2025 11:43
bcb9eeb
to
9b06082
Compare
fix types, add tests, fix tests, fix manual e2e
renamed all per comments to better fit naming schemes
feat: add-device-client
github-actions
bot
force-pushed
the
changeset-release/master
branch
from
January 27, 2025 16:01
9b06082
to
aa8c074
Compare
updates vite per mend scan and update nx per trying to update vite
chore: update-vite-nx
github-actions
bot
force-pushed
the
changeset-release/master
branch
from
January 27, 2025 16:34
aa8c074
to
8ffe4e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.
Releases
@forgerock/[email protected]
Minor Changes
db41dcc
Thanks @ryanbas21! - add-device-clientPatch Changes
5119dc0
Thanks @cerebrl! - In order to display a more user-friendly name when saving a WebAuthn/Passkey device to an account, we prioritized displayName over userName for assignment to thename
property of the WebAuthn options object. This avoids the display of UUIDs for saved credentials.@forgerock/[email protected]
Patch Changes
5119dc0
,db41dcc
]:@forgerock/[email protected]
Patch Changes
5119dc0
,db41dcc
]:@forgerock/[email protected]
Patch Changes
5119dc0
,db41dcc
]:Security: - Proxy config declaring URLs is now required and will be used to generate an allow list of origins to check again prior to fowarding a request.