Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with external type bound procedures without local overwrite #677

Merged
merged 12 commits into from
Jan 23, 2025

Conversation

haraldkl
Copy link
Contributor

An attempt to address #676.

@haraldkl haraldkl changed the title Add "proto" attribute to be externalized Deal with external type bound procedures without local overwrite Nov 16, 2024
Copy link
Contributor Author

@haraldkl haraldkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #676, but not very elegantly. Somehow the externalization stuff bleeds into the templates/macros.html, which does not seem very desirable. The logic for external in the progress of the correlate methods may also be needed elsewhere, and maybe it would be better to overwrite the correlate functions for the External* classes.

ford/external_project.py Show resolved Hide resolved
ford/external_project.py Show resolved Hide resolved
ford/graphs.py Show resolved Hide resolved
ford/sourceform.py Show resolved Hide resolved
ford/templates/macros.html Show resolved Hide resolved
ford/templates/macros.html Show resolved Hide resolved
ford/templates/macros.html Show resolved Hide resolved
ford/templates/macros.html Show resolved Hide resolved
@haraldkl haraldkl marked this pull request as ready for review November 16, 2024 23:11
@ZedThree
Copy link
Member

Thanks @haraldkl! Not had chance to go through this properly yet, but it looks good so far!

@ZedThree
Copy link
Member

This looks great, thanks @haraldkl! Sorry it's taken me so long to look at it. Does this change the format of the JSON file at all (that is, is it backwards compatible)?

@haraldkl
Copy link
Contributor Author

Does this change the format of the JSON file at all (that is, is it backwards compatible)?

It only adds the deferred and attribs attributes to consider, but it should still work the same as before for existing JSON files (except that we do not recurse down the graph any further).

Copy link
Member

@ZedThree ZedThree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @haraldkl, it's really appreciated!

@ZedThree ZedThree merged commit f420a03 into Fortran-FOSS-Programmers:master Jan 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants