-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deal with external type bound procedures without local overwrite #677
Deal with external type bound procedures without local overwrite #677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes #676, but not very elegantly. Somehow the externalization stuff bleeds into the templates/macros.html, which does not seem very desirable. The logic for external in the progress of the correlate
methods may also be needed elsewhere, and maybe it would be better to overwrite the correlate
functions for the External*
classes.
Thanks @haraldkl! Not had chance to go through this properly yet, but it looks good so far! |
This looks great, thanks @haraldkl! Sorry it's taken me so long to look at it. Does this change the format of the JSON file at all (that is, is it backwards compatible)? |
It only adds the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @haraldkl, it's really appreciated!
An attempt to address #676.