Fix widgets getting stuck or disappearing #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Widget gridItem is created with widgetId -1. When a Widget was binded for the first time, a widgetId is generated by appWidgetHost. However, this widgetId was not saved at DB. During an onResume(), refreshLaunchers() would be called, and then call fetchGridItems(). This would reset the widgetId to -1 and disconnect it from the widgetId generated by appWidgetHost, causing weird behaviors. Another problem is that a new widgetId was being generated everytime we replaced the Widget at a restart process. Changed so bindWidget() is only called when binding the Widget for the first time, and then we save the widgetId at the DB. Later on, when recreating the screen, we retrieve the widgetId from DB and call placeAppWidget() to replace the Widget were it was. Signed-off-by: Rafael Rondão <[email protected]>
Your PR has fixed it too. |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
A Widget
gridItemis created withwidgetId -1.When a Widget was binded for the first time, a
widgetIdis generated byappWidgetHost.However, this
widgetIdwas not saved at DB.During an
onResume(),refreshLaunchers()would be called, and then callfetchGridItems().This would reset the
widgetIdto-1and disconnect it from thewidgetIdgenerated byappWidgetHost, causing weird behaviors.Another problem is that a new
widgetIdwas being generated everytime we replaced the Widget at a restart process.Changed so
bindWidget()is only called when binding the Widget for the first time, and then we save thewidgetIdat the DB.Later on, when recreating the screen, we retrieve the
widgetIdfrom DB and callplaceAppWidget()to replace the Widget where it was.Fixes the following issue(s)
There are many Widget related issues.
Acknowledgement