Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint before build #2315

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Lint before build #2315

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
288235f
Move lint tasks before build
Diokuz Jun 27, 2017
99a80f5
brake linter for test purposes
Diokuz Jun 27, 2017
4ed3ee7
Revert "brake linter for test purposes"
Diokuz Jun 27, 2017
5a891f3
test
Diokuz Jun 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions ashes/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export GIT_COMMIT = $(shell git rev-parse --short HEAD)
export URL_PREFIX = /admin
WEBPACK_PORT = 4001

.PHONY: notify
notify:
$(call header, $(MSG))

Expand All @@ -26,17 +27,17 @@ CFLAGS = -c -g -D $(NODE_ENV)
version = $(shell iojs -e "console.log(JSON.parse(require('fs').readFileSync('package.json')).version)")

.PHONY: docker
docker: MSG=Dockerizing
docker: notify
docker:
MSG=Dockerizing make notify
docker build -t $(DOCKER_IMAGE) . --build-arg NPM_TOKEN=${NPM_TOKEN}

.PHONY: docker-run
docker-run:
docker run -it -p 4000:4000 ashes:latest

.PHONY: docker-push
docker-push: MSG=Registering
docker-push: notify
docker-push:
MSG=Registering make notify
docker tag $(DOCKER_IMAGE) $(DOCKER_REPO)/$(DOCKER_IMAGE):$(DOCKER_TAG)
docker push $(DOCKER_REPO)/$(DOCKER_IMAGE):$(DOCKER_TAG)

Expand All @@ -52,12 +53,17 @@ tag:
clean:
rm -rf ./build/admin

# Do we actually need tests (not checks) on built aplication inside Ashes?
.PHONY: test
test: MSG=Testing
test: notify flow lint mocha
test:
MSG=Testing make notify

.PHONY: t
t: flow lint mocha
.PHONY: notify-check
notify-check:
MSG=Checking make notify

.PHONY: check t
check t: notify-check flow lint mocha

.PHONY: mocha-spec
mocha-spec:
Expand Down Expand Up @@ -97,6 +103,7 @@ fmt-%:

.PHONY: build-styleguide
build-styleguide:
MSG="Building Styleguilde" make notify
styleguidist build --config styleguide/config.styleguide.js

.PHONY: styleguide sg
Expand All @@ -107,6 +114,7 @@ styleguide sg:

.PHONY: install i
install i:
MSG=Installing make notify
rm -rf ./node_modules
yarn cache clean
yarn --pure-lockfile
Expand All @@ -131,6 +139,7 @@ dev d:

.PHONY: build-prod
build-prod:
MSG="Building Application" make notify
NODE_ENV=production webpack --progress

.PHONY: prod p
Expand All @@ -140,5 +149,4 @@ prod p: clean build-prod
# Buildkite ###

.PHONY: build
build: MSG=Building
build: notify clean install build-styleguide build-prod
build: clean install check build-styleguide build-prod