Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding deprecation notice to the card expiry notification option #26

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

adamjudd
Copy link
Contributor

@adamjudd adamjudd commented Nov 9, 2018

This PR adds a deprecation notice to the card expiry notification option on the settings page. It piggy backs a little on the normal warning styles of the WP admin, adding a custom class for FoxyShop as WordPress pulls those notices up to the top of the page.

It also hides the option completely if it's not already checked.

We'll remove that functionality completely in a future version.

Relates to #11

@rijarobinson rijarobinson merged commit ea276af into master Nov 14, 2018
@rijarobinson
Copy link
Contributor

Looks good.

@rijarobinson rijarobinson deleted the polish/deprecate-expiring-cards-reminder branch November 14, 2018 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants